Fixes to User #174
Open
Fixes to User #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up if does not exist.
kientzle
reviewed
Jan 22, 2017
|
|
||
| if [ $? > 2 ]; then | ||
| USER=$1 | ||
| shift | ||
| for GROUP in $@; do | ||
| # Group can be added by pkg, ensure this happens after pkg install in "option Package". | ||
| PRIORITY=110 strategy_add $PHASE_FREEBSD_BOARD_INSTALL pw_add_user_to_group $USER $GROUP | ||
| PRIORITY=110 strategy_add $PHASE_FREEBSD_OPTION_INSTALL pw_add_user_to_group $USER $GROUP |
There was a problem hiding this comment.
The strategy sort is stable, so you don't actually need different priorities here, as long as pw_create_account is added before pw_add_user_to_group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected strategy_add from BOARD_INSTALL to OPTION_INSTALL (otherwise it will be run before pkg install).
Added create group if does not exist.