Skip to content

Commit

Permalink
mobile: Deflake BidirectionalStreamTest (envoyproxy#36412)
Browse files Browse the repository at this point in the history
I still don't fully understand how removing the `shutdown` fixes the
issue. Although it doesn't completely fix the flakiness but it reduces
the flakiness by a lot.

Risk Level: low (tests only)
Testing: `bazel test --runs_per_test=100
//test/java/org/chromium/net:bidirectional_stream_test`
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
  • Loading branch information
fredyw authored Oct 1, 2024
1 parent 7fb0318 commit 907c370
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion mobile/test/java/org/chromium/net/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ envoy_mobile_android_test(
srcs = [
"BidirectionalStreamTest.java",
],
flaky = True, # TODO(fredyw): Debug the reason for it being flaky.
flaky = True,
native_deps = [
"//test/jni:libenvoy_jni_with_test_extensions.so",
] + select({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ public void setUp() throws Exception {
@After
public void tearDown() throws Exception {
assertTrue(Http2TestServer.shutdownHttp2TestServer());
if (mCronetEngine != null) {
mCronetEngine.shutdown();
}
}

private static void checkResponseInfo(UrlResponseInfo responseInfo, String expectedUrl,
Expand Down

0 comments on commit 907c370

Please sign in to comment.