opentelemetry: add the option to discard buffer response body for htt…

…p async exporter (envoyproxy#35572) only the response code is used for logging purpose. Risk Level: low Testing: unit test Signed-off-by: Boteng Yao <[email protected]>
fredyw · Aug 7, 2024 · 84e1ed2 · 84e1ed2
1 parent d78e813
commit 84e1ed2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/source/extensions/tracers/opentelemetry/http_trace_exporter.cc b/source/extensions/tracers/opentelemetry/http_trace_exporter.cc
@@ -61,8 +61,11 @@ bool OpenTelemetryHttpTraceExporter::log(const ExportTraceServiceRequest& reques
   }
   message->body().add(request_body);
 
-  const auto options = Http::AsyncClient::RequestOptions().setTimeout(std::chrono::milliseconds(
-      DurationUtil::durationToMilliseconds(http_service_.http_uri().timeout())));
+  const auto options =
+      Http::AsyncClient::RequestOptions()
+          .setTimeout(std::chrono::milliseconds(
+              DurationUtil::durationToMilliseconds(http_service_.http_uri().timeout())))
+          .setDiscardResponseBody(true);
 
   Http::AsyncClient::Request* in_flight_request =
       thread_local_cluster->httpAsyncClient().send(std::move(message), *this, options);

diff --git a/test/extensions/tracers/opentelemetry/http_trace_exporter_test.cc b/test/extensions/tracers/opentelemetry/http_trace_exporter_test.cc
@@ -70,9 +70,11 @@ TEST_F(OpenTelemetryHttpTraceExporterTest, CreateExporterAndExportSpan) {
   Http::MockAsyncClientRequest request(&cluster_manager_.thread_local_cluster_.async_client_);
   Http::AsyncClient::Callbacks* callback;
 
-  EXPECT_CALL(
-      cluster_manager_.thread_local_cluster_.async_client_,
-      send_(_, _, Http::AsyncClient::RequestOptions().setTimeout(std::chrono::milliseconds(250))))
+  EXPECT_CALL(cluster_manager_.thread_local_cluster_.async_client_,
+              send_(_, _,
+                    Http::AsyncClient::RequestOptions()
+                        .setTimeout(std::chrono::milliseconds(250))
+                        .setDiscardResponseBody(true)))
       .WillOnce(
           Invoke([&](Http::RequestMessagePtr& message, Http::AsyncClient::Callbacks& callbacks,
                      const Http::AsyncClient::RequestOptions&) -> Http::AsyncClient::Request* {