test: fixed race condition in postgres integration test (envoyproxy#3…

…0354) Commit Message: fixed race condition in postgres integration test Additional Description: Typical race condition. Reply was received before calling clearData, which basically dropped received reply. Risk Level: Low Testing: Verified that previously failing test does not fail anymore. Docs Changes: No Release Notes: No Platform Specific Features: No Fixes envoyproxy#30330 Signed-off-by: Christoph Pakulski <[email protected]>
fredyw · Oct 20, 2023 · 775f3a6 · 775f3a6
1 parent dc841d1
commit 775f3a6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/contrib/postgres_proxy/filters/network/test/postgres_integration_test.cc b/contrib/postgres_proxy/filters/network/test/postgres_integration_test.cc
@@ -610,12 +610,12 @@ TEST_P(UpstreamAndDownstreamSSLIntegrationTest, ServerAgreesForSSL) {
   // Reply to Envoy with 'S' and attach TLS socket to upstream.
   upstream_data.add("S");
   ASSERT_TRUE(fake_upstream_connection_->write(upstream_data.toString()));
+  fake_upstream_connection_->clearData();
 
   config_factory_.recv_sync_.WaitForNotification();
   enableTLSOnFakeUpstream();
   config_factory_.proceed_sync_.Notify();
 
-  fake_upstream_connection_->clearData();
   ASSERT_TRUE(fake_upstream_connection_->waitForData(data.length(), &rcvd));
   // Make sure that upstream received initial postgres request, which
   // triggered upstream SSL negotiation and TLS handshake.