Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Target Switcher Fix #290

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

rdr6000
Copy link

@rdr6000 rdr6000 commented Aug 7, 2024

The progress target switcher had a bug where if the props.tabs?.[0] == 'string' was false, no value property would be created, which in turn would send undefined in this emit emit('update:modelValue', tab.value) . Instead we can just return emit('update:modelValue', tab)

This directly works with @update:model-value="$emit('tab-change', $event.label)" in InputWithTabs.vue.

Target Tab switching is working in Progess after this change

@rdr6000 rdr6000 closed this Aug 16, 2024
@rdr6000 rdr6000 reopened this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant