Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): dev to main #1987

Merged
merged 17 commits into from
Sep 17, 2024
Merged

chore(release): dev to main #1987

merged 17 commits into from
Sep 17, 2024

Conversation

balamurali27
Copy link
Contributor

No description provided.

balamurali27 and others added 17 commits September 13, 2024 14:54
A doctype to add custom synonyms for words
Eg: database <-> db, mariadb <-> mysql

Need to regenerate index to take effect
fix(HelpdeskSearch): Minor improvements
Need to be plain search for synonym detection to work

- Use fuzzy for large words
- Use substr for small words
fix(HelpdeskSearch): Use synonyms correctly and add fuzzy back
fix(HelpdeskSearch): Correct querying
fix(HDSettings): Add default values for weights for ux
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes missing coverage. Please review.

Project coverage is 30.79%. Comparing base (b882193) to head (6c31c16).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
helpdesk/search.py 36.00% 16 Missing ⚠️
helpdesk/helpdesk/doctype/hd_synonym/hd_synonym.py 0.00% 3 Missing ⚠️
...lpdesk/helpdesk/doctype/hd_synonyms/hd_synonyms.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
- Coverage   30.96%   30.79%   -0.18%     
==========================================
  Files          63       65       +2     
  Lines        2070     2098      +28     
==========================================
+ Hits          641      646       +5     
- Misses       1429     1452      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balamurali27 balamurali27 merged commit 34c4b11 into main Sep 17, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants