chore: Merge develop to main #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add helpdesk to apps page
chore(README): update screenshot
fix: add missing order by in List Manager's client helper
- Search headings separately - Reduce page length - Change weights - Summarize description in search results
feat(TicketsAgent): export tickets list in excel,csv format
feat: allow selected rows to be exported
- Change search algorithm to BM25. Seems to give better results - Reduce fuzzyness as it seems to mess with accuracy for small words (ssh, site, row, etc)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ling fix: show proper error message
fix(HelpdeskSearch): Improve search of knowledge base articles
Need to filter in query manually as we do fuzzy search of all words
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fix(HelpdeskSearch): Add custom stopwords
…esults needs nltk
Increase default score of all docs. More likely to return results
fix(HelpdeskSearch): Optimistically retreive results
Effectively same and compatible with redis 7.4
fix: scroll to view from Hash
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -240,3 +334,13 @@ def build_index_if_not_exists(): | |||
| search = HelpdeskSearch() | |||
| if not search.index_exists(): | |||
| build_index() | |||
|
|
|||
| @filelock("helpdesk_corpus_download", timeout=60) | |||
There was a problem hiding this comment.
[black-format] reported by reviewdog 🐶
Suggested change
| @filelock("helpdesk_corpus_download", timeout=60) | |
| @filelock("helpdesk_corpus_download", timeout=60) |
| @filelock("helpdesk_corpus_download", timeout=60) | ||
| def download_corpus(): | ||
| from nltk import download, data | ||
| try: |
There was a problem hiding this comment.
[black-format] reported by reviewdog 🐶
Suggested change
| try: | |
| try: |
| @@ -61,7 +61,7 @@ | |||
| </template> | |||
|
|
|||
| <script setup lang="ts"> | |||
| import { ref, computed } from "vue"; | |||
| import { ref, computed, h } from "vue"; | |||
There was a problem hiding this comment.
'h' is defined but never used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
+ Coverage 31.31% 31.33% +0.02%
==========================================
Files 61 61
Lines 1977 2020 +43
==========================================
+ Hits 619 633 +14
- Misses 1358 1387 +29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.