Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ux): ticket details: auto save #1369

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jul 27, 2023

  • Remove save button
  • Remove keymaps

related: #1325

- Remove save button
- Remove keymaps
@ssiyad ssiyad added the enhancement New feature or request label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.20% 🎉

Comparison is base (75e655f) 12.87% compared to head (07d7e7a) 13.08%.
Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
+ Coverage   12.87%   13.08%   +0.20%     
==========================================
  Files          52       57       +5     
  Lines        1848     1957     +109     
==========================================
+ Hits          238      256      +18     
- Misses       1610     1701      +91     
Files Changed Coverage Δ
helpdesk/__init__.py 100.00% <ø> (ø)
helpdesk/consts.py 100.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_agent/hd_agent.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/api.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...lpdesk/helpdesk/doctype/hd_article_category/api.py 0.00% <ø> (ø)
...doctype/hd_article_category/hd_article_category.py 0.00% <ø> (ø)
...lpdesk/helpdesk/doctype/hd_customer/hd_customer.py 0.00% <ø> (-38.10%) ⬇️
...hd_desk_account_request/hd_desk_account_request.py 0.00% <ø> (ø)
...k/doctype/hd_escalation_rule/hd_escalation_rule.py 0.00% <ø> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad merged commit 63f3247 into frappe:main Jul 27, 2023
8 checks passed
@ssiyad ssiyad deleted the feat/ux/ticket_detail_autosave branch July 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant