Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ticket: refactor #1286

Merged
merged 12 commits into from
Jun 28, 2023
Merged

feat: ticket: refactor #1286

merged 12 commits into from
Jun 28, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jun 28, 2023

Override #1285

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.33 🎉

Comparison is base (75e655f) 12.87% compared to head (6a5c64a) 13.21%.

❗ Current head 6a5c64a differs from pull request most recent head 8474ffb. Consider uploading reports for the commit 8474ffb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   12.87%   13.21%   +0.33%     
==========================================
  Files          52       53       +1     
  Lines        1848     1900      +52     
==========================================
+ Hits          238      251      +13     
- Misses       1610     1649      +39     
Impacted Files Coverage Δ
helpdesk/__init__.py 100.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...hd_desk_account_request/hd_desk_account_request.py 0.00% <ø> (ø)
...k/doctype/hd_escalation_rule/hd_escalation_rule.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 21.86% <ø> (-0.66%) ⬇️
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <ø> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <ø> (ø)
helpdesk/utils.py 39.13% <ø> (+39.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad marked this pull request as ready for review June 28, 2023 19:27
@ssiyad ssiyad merged commit 670d2c4 into frappe:main Jun 28, 2023
@ssiyad ssiyad deleted the feat/tickets_fetch_counts branch June 28, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant