Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace: router-link with RouterLink #1277

Merged
merged 1 commit into from
Jun 20, 2023
Merged

chore: replace: router-link with RouterLink #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desk/src/components/desk/kb/ArticleDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="flex flex-col rounded shadow p-5 text-base space-y-[12px]">
<div class="font-semibold">Details</div>
<div class="border-b w-full"></div>
<router-link
<RouterLink

Check failure on line 5 in desk/src/components/desk/kb/ArticleDetails.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹` with `····`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹` with `····`","line":5,"column":1,"nodeType":null,"messageId":"replace","endLine":5,"endColumn":3,"fix":{"range":[165,167],"text":"    "}}
:to="`/knowledge-base/articles/${article.name}`"
target="_blank"
v-if="article.published_on"
Expand All @@ -18,7 +18,7 @@
}}
</div>
<FeatherIcon name="external-link" class="w-4" />
</router-link>
</RouterLink>

Check failure on line 21 in desk/src/components/desk/kb/ArticleDetails.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹` with `····`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹` with `····`","line":21,"column":1,"nodeType":null,"messageId":"replace","endLine":21,"endColumn":3,"fix":{"range":[530,532],"text":"    "}}
<div v-if="$resources.users.data" class="flex flex-col">
<span class="block mb-2 text-sm leading-4 text-gray-700">
Author
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/SettingsSideBarMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
class="cursor-pointer px-3 hover:bg-gray-50 rounded-md mx-2 mb-1"
:class="selectedSetting === setting.label ? 'bg-gray-50' : ''"
>
<router-link :to="{ name: setting.pageName }">
<RouterLink :to="{ name: setting.pageName }">

Check failure on line 8 in desk/src/components/desk/settings/SettingsSideBarMenu.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹↹` with `········`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹↹` with `········`","line":8,"column":1,"nodeType":null,"messageId":"replace","endLine":8,"endColumn":5,"fix":{"range":[267,271],"text":"        "}}
<div class="p-2 text-base">
{{ setting.label }}
</div>
</router-link>
</RouterLink>

Check failure on line 12 in desk/src/components/desk/settings/SettingsSideBarMenu.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹↹` with `········`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹↹` with `········`","line":12,"column":1,"nodeType":null,"messageId":"replace","endLine":12,"endColumn":5,"fix":{"range":[388,392],"text":"        "}}
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/canned_responses/CannedResponseInfo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<div class="min-w-[490px] px-[24px] py-[10px]">
<div class="flow-root h-[72px] shrink-0 py-[22px] px-[16px]">
<div class="float-left">
<router-link
<RouterLink
to="/canned-responses"
class="my-1 flex select-none flex-row items-center space-x-1 stroke-gray-600 text-sm text-gray-600 hover:stroke-gray-700 hover:text-gray-700"
role="button"
>
<FeatherIcon name="arrow-left" class="h-[13px] w-[13px]" />
<div>Back to response list</div>
</router-link>
</RouterLink>
</div>
<div class="float-right">
<div v-if="!editMode" class="flex flex-row space-x-2">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/canned_responses/CannedResponseListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
role="button"
/>
</div>
<router-link
<RouterLink

Check failure on line 19 in desk/src/components/desk/settings/canned_responses/CannedResponseListItem.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹` with `······`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹` with `······`","line":19,"column":1,"nodeType":null,"messageId":"replace","endLine":19,"endColumn":4,"fix":{"range":[430,433],"text":"      "}}
:to="`/settings/canned_responses/${canned_response.name}`"
class="w-full group flex items-center"
>
Expand All @@ -27,7 +27,7 @@
{{ canned_response.owner }}
</div>
<div class="sm:w-2/12 truncate"></div>
</router-link>
</RouterLink>

Check failure on line 30 in desk/src/components/desk/settings/canned_responses/CannedResponseListItem.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹` with `······`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹` with `······`","line":30,"column":1,"nodeType":null,"messageId":"replace","endLine":30,"endColumn":4,"fix":{"range":[774,777],"text":"      "}}
</div>
</div>
</template>
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/emails/EmailListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
/>
</div>
<div class="w-full group flex items-center">
<router-link
<RouterLink

Check failure on line 16 in desk/src/components/desk/settings/emails/EmailListItem.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹↹` with `········`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹↹` with `········`","line":16,"column":1,"nodeType":null,"messageId":"replace","endLine":16,"endColumn":5,"fix":{"range":[449,453],"text":"        "}}
:to="`/settings/emails/${emailAccount.name}`"
class="sm:w-4/12"
>
{{ emailAccount.name }}
</router-link>
</RouterLink>

Check failure on line 21 in desk/src/components/desk/settings/emails/EmailListItem.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹↹` with `········`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹↹` with `········`","line":21,"column":1,"nodeType":null,"messageId":"replace","endLine":21,"endColumn":5,"fix":{"range":[574,578],"text":"        "}}
<div class="sm:w-5/12">
{{ emailAccount.email_id }}
</div>
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/policies/SlaPolicyListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/>
</div>
<div class="w-full group flex items-center">
<router-link
<RouterLink

Check failure on line 16 in desk/src/components/desk/settings/policies/SlaPolicyListItem.vue

View workflow job for this annotation

GitHub Actions / ESLint - Reviewdog 

[eslint] reported by reviewdog 🐶
Replace `↹↹↹↹` with `········`

Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `↹↹↹↹` with `········`","line":16,"column":1,"nodeType":null,"messageId":"replace","endLine":16,"endColumn":5,"fix":{"range":[457,461],"text":"        "}}
:to="`/settings/sla/${policy.name}`"
class="sm:w-10/12 truncate pr-10 flex flex-row items-center space-x-2"
>
Expand All @@ -27,7 +27,7 @@
class="w-[16px] h-[16px] fill-blue-500"
/>
</a>
</router-link>
</RouterLink>
<div class="sm:w-2/12">
<div class="flex flex-row-reverse">
<CustomSwitch
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/teams/TeamInfo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<div class="min-w-[490px] px-[24px] py-[10px]">
<div class="flow-root h-[72px] shrink-0 py-[22px] px-[16px]">
<div class="float-left">
<router-link
<RouterLink
:to="`/teams`"
class="my-1 flex select-none flex-row items-center space-x-1 stroke-gray-600 text-sm text-gray-600 hover:stroke-gray-700 hover:text-gray-700"
role="button"
>
<FeatherIcon name="arrow-left" class="h-[13px] w-[13px]" />
<div>Back to team list</div>
</router-link>
</RouterLink>
</div>
<div class="float-right">
<div class="flex flex-row space-x-2">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/desk/settings/ticket_types/TicketTypeInfo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<div class="min-w-[490px] px-[24px] py-[10px]">
<div class="flow-root h-[72px] shrink-0 py-[22px] px-[16px]">
<div class="float-left">
<router-link
<RouterLink
:to="`/ticket-types`"
class="my-1 flex select-none flex-row items-center space-x-1 stroke-gray-600 text-sm text-gray-600 hover:stroke-gray-700 hover:text-gray-700"
role="button"
>
<FeatherIcon name="arrow-left" class="h-[13px] w-[13px]" />
<div>Back to ticket type list</div>
</router-link>
</RouterLink>
</div>
<div class="float-right">
<div class="flex flex-row space-x-2">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/global/kb/ArticleCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<router-link :to="`/knowledge-base/articles/${article.name}`">
<RouterLink :to="`/knowledge-base/articles/${article.name}`">
<div
class="group rounded-[6px] shadow-md bg-white p-5 w-full flex flex-row justify-between items-center hover:bg-gray-50"
>
Expand All @@ -11,7 +11,7 @@
class="h-4 w-4 group-hover:visible invisible"
/>
</div>
</router-link>
</RouterLink>
</template>

<script>
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/global/kb/ArticleMiniList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
<!-- TODO: <FeatherIcon v-if="editMode" name="plus" class="w-4 cursor-pointer my-auto bg-gray-50 hover:bg-gray-100 rounded" /> -->
<p v-if="editMode" class="text-base text-gray-500">
( add articles from
<router-link class="underline" :to="{ path: '/kb/articles' }"
>here</router-link
<RouterLink class="underline" :to="{ path: '/kb/articles' }"
>here</RouterLink
>
)
</p>
Expand Down
8 changes: 4 additions & 4 deletions desk/src/components/global/kb/LayoutSwitcher.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
v-if="viewMode === 'Web'"
class="flex flex-row items-center space-x-2"
>
<router-link
<RouterLink
:title="'Articles'"
:to="{
path: '/kb/articles',
Expand All @@ -15,7 +15,7 @@
name="list"
class="h-5 w-5 ml-2 stroke-gray-500 hover:stroke-gray-900"
/>
</router-link>
</RouterLink>
<div
class="bg-white rounded-md shadow px-2 py-0.5 w-[82px] h-[24px]"
>
Expand All @@ -28,7 +28,7 @@
>
<div>Articles</div>
</div>
<router-link
<RouterLink
:title="'Toggle Web view'"
:to="{ path: '/kb' }"
>
Expand All @@ -37,7 +37,7 @@
name="layout"
class="h-5 w-5 mr-2 stroke-gray-500 hover:stroke-gray-900"
/>
</router-link>
</RouterLink>
</div>
</div>
</template>
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/global/kb/SearchSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
v-for="(result, index) in searchResults"
:key="result.name"
>
<router-link
<RouterLink
:to="{
path: `/knowledge-base/${
result.doctype === 'Article'
Expand Down Expand Up @@ -82,7 +82,7 @@
<div>{{ result.title }}</div>
</div>
</div>
</router-link>
</RouterLink>
</div>
</div>
<div v-else class="p-2 text-gray-500">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/components/global/ticket_list_item/Subject.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<router-link
<RouterLink
:to="{
path: `/tickets/${ticket.name}`,
}"
Expand All @@ -12,7 +12,7 @@
}"
>
{{ ticket.subject }}
</router-link>
</RouterLink>
</template>

<script setup lang="ts">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/pages/desk/kb/Articles.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@
</div>
</template>
<template #field-title="{ value, row }">
<router-link
<RouterLink
:to="{
path: `/kb/articles/${row.name}`,
}"
class="cursor-pointer text-gray-600 hover:text-gray-900"
>{{ value }}</router-link
>{{ value }}</RouterLink
>
</template>
<template #field-status="{ value }">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/pages/desk/sla/SlaPolicies.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
>
<template #field-name="{ row }">
<div class="group flex w-full items-center">
<router-link
<RouterLink
:to="{
path: `/sla/${row.name}`,
}"
Expand All @@ -54,7 +54,7 @@
class="h-[16px] w-[16px] fill-blue-500"
/>
</a>
</router-link>
</RouterLink>
</div>
</template>
<template #field-enabled="{ row }">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/pages/desk/ticket-list/TicketSummary.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<router-link
<RouterLink
:to="toRoute"
class="flex justify-between"
:class="{
Expand Down Expand Up @@ -32,7 +32,7 @@
{{ ticketName }}
</div>
</div>
</router-link>
</RouterLink>
</template>

<script setup lang="ts">
Expand Down
4 changes: 2 additions & 2 deletions desk/src/pages/desk/ticket/OpenTicketList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
</div>
<div v-if="isExpanded" class="flex flex-col gap-2 pt-4">
<div v-for="t in tickets" :key="t.name">
<router-link :to="t.to" target="_blank" class="flex items-start gap-2">
<RouterLink :to="t.to" target="_blank" class="flex items-start gap-2">
<div class="flex h-5 w-5 items-center justify-center">
<IconWebLink class="h-5 w-5 text-gray-600" />
</div>
<div class="text-base text-gray-800">{{ t.subject }}</div>
</router-link>
</RouterLink>
</div>
</div>
</div>
Expand Down
Loading