Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to 'soh' #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename to 'soh' #96

wants to merge 1 commit into from

Conversation

stappersg
Copy link

@stappersg stappersg commented Jan 4, 2024

Two main reasons:

  • Dropped the 3 to be ready for HTTP/2
  • Avoiding confusion with OpenSSH. ( We don't want to panic SSH users to update their SSH. And we don't want to keep explaining this project is not next OpenSSH release.)

For reproducing this large change:

vi +/stand README.md
grep -rl ssh3 | grep -v .git/ | xargs sed --in-place -e 's/ssh3/soh/g'
grep -rl SSH3 | grep -v .git/ | xargs sed --in-place -e 's/SSH3/SOH/g'
find . -name '*ssh3*' -type f
git mv s{sh3,oh}_suite_test.go
git mv integration_tests/s{sh3,oh}_test.go
cd resources/figures/
git mv s{sh3,oh}.png
git mv s{sh3,oh}_oidc.gif
git mv s{sh3,oh}_100ms_rtt.gif
cd -
find . -name '*ssh3*' -type f  # all ssh3 filenames gone?

This change as "point of view from git":
35 files changed, 351 insertions(+), 351 deletions(-)
rename integration_tests/{ssh3_test.go => soh_test.go} (90%)
rename resources/figures/{ssh3.png => soh.png} (100%)
rename resources/figures/{ssh3_100ms_rtt.gif => soh_100ms_rtt.gif} (100%)
rename resources/figures/{ssh3_oidc.gif => soh_oidc.gif} (100%)
rename ssh3_suite_test.go => soh_suite_test.go (90%)

@francoismichel
Copy link
Owner

Thanks for the PR. I think it might make sense to rebase ith with the upstream that not integrates proxy jump. That will be useful for distros.

@stappersg
Copy link
Author

stappersg commented Jan 10, 2024 via email

@francoismichel
Copy link
Owner

Sorry, I meant "now", instead of "not". The current upstream now integrates ProxyJump and enhanced logging, that will be useful for soh when packaged. :-)

Two main reasons:
* Dropped the 3 to be ready for HTTP/2
* Avoiding confusion with OpenSSH.  ( We don't want
  to panic SSH users to update their SSH. And we don't
  want to keep explaining this project is not next OpenSSH
  release.)

For reproducing this large change:

vi +/stand README.md
grep -rl ssh3 | grep -v .git/ | xargs sed --in-place -e 's/ssh3/soh/g'
grep -rl SSH3 | grep -v .git/ | xargs sed --in-place -e 's/SSH3/SOH/g'
find . -name '*ssh3*' -type f
git mv s{sh3,oh}_suite_test.go
git mv integration_tests/s{sh3,oh}_test.go
cd resources/figures/
git mv s{sh3,oh}.png
git mv s{sh3,oh}_oidc.gif
git mv s{sh3,oh}_100ms_rtt.gif
cd -
find . -name '*ssh3*' -type f  # all ssh3 filenames gone?

This change as "point of view from git":
 35 files changed, 351 insertions(+), 351 deletions(-)
 rename integration_tests/{ssh3_test.go => soh_test.go} (90%)
 rename resources/figures/{ssh3.png => soh.png} (100%)
 rename resources/figures/{ssh3_100ms_rtt.gif => soh_100ms_rtt.gif} (100%)
 rename resources/figures/{ssh3_oidc.gif => soh_oidc.gif} (100%)
 rename ssh3_suite_test.go => soh_suite_test.go (90%)

Signed-off-by: Geert Stappers <[email protected]>
@stappersg
Copy link
Author

rebased

@francoismichel
Copy link
Owner

Sooo, I think the v0.1.6 is the real good candidate for here, as it integrates a lot of important stuff, including improved logging and proper version negotiation that will both help distro users. Can I ask a last rebase before my green light ? :-)

I can do it myself if needed.

@stappersg
Copy link
Author

stappersg commented Jan 17, 2024 via email

@stappersg
Copy link
Author

stappersg commented Feb 11, 2024 via email

@stappersg
Copy link
Author

ping a.k.a. ICMP echo request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants