Enable HTTP proxy support #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoismichel
force-pushed
the
proxy-support
branch
from
f40190f
to
be3811d
Compare
Merged
mpiraux
reviewed
Jan 4, 2024
This was referenced Jan 8, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, HTTP proxies cannot be used as privkey and OIDC authentication explicitly sign the conversation ID derived by TLS exporters, binding the SSH3 conversation to the TLS session.
This PR adds support for proxies (cf #67, and #44 to a lesser extent). If explicitly set by the user, the conversation ID is removed from the auth token claims and the server relies on the expiration (
exp) claim to prevent replay attacks. When proxy support is enabled, the user authentication token is valid for 1 minute and can therefore be used by proxies during that time window.Proxies must therefore be trusted during that minute, as they could reuse that token for themselve, as it is the case for any HTTP authentication process relying on Bearer tokens. 1 minute is considered reasonable as it is a smaller duration than most popular SSO platforms and should be long enough to traverse the Internet.