Add new event and modify some workflow #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added a new event
AttemptSucceded
and changed the way events are fired.Now we have two main events:
They are split into four events:
AttemptFailed
fired by attempt method;AttemptSucceeded
fired by attempt method;ServiceFailed
fired by attempt method when the previous state is changed;ServiceRestored
fired by attempt method when the previous state is changed.Motivation and context
We need to notify our slack uptime channel when circuit breaker is fired or a service is restored.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Since the package don't have tests for event firing, I haven't built them.