Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyyaml and docker-compose dependencies #816

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Fix pyyaml and docker-compose dependencies #816

merged 5 commits into from
Aug 23, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Aug 22, 2023

Close #813

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Coverage report

The coverage rate went from 91.83% to 91.76% ⬇️
The branch rate is 81%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@tcompa
Copy link
Collaborator Author

tcompa commented Aug 22, 2023

CI failure with pytest-docker v2 -> to check.

Meanwhile, this PR would also have the nice effect of removing quite a few (dev) dependencies, which never hurts ;)

@tcompa
Copy link
Collaborator Author

tcompa commented Aug 22, 2023

Some details from a (local) CI failure:

    def execute(command, success_codes=(0,)):
        """Run a shell command."""
        try:
            output = subprocess.check_output(command, stderr=subprocess.STDOUT, shell=True)
            status = 0
        except subprocess.CalledProcessError as error:
            output = error.output or b""
            status = error.returncode
            command = error.cmd
    
        if status not in success_codes:
>           raise Exception(
                'Command {} returned {}: """{}""".'.format(
                    command, status, output.decode("utf-8")
                )
            )
E           Exception: Command docker compose -f "/home/tommaso/Fractal/fractal-server/tests/data/slurm_docker_images/docker-compose.yml" -p "pytest98522" up --build -d returned 125: """unknown shorthand flag: 'f' in -f

EDIT: this is most likely due to my own docker version

@tcompa tcompa requested a review from mfranzon August 23, 2023 11:36
@tcompa
Copy link
Collaborator Author

tcompa commented Aug 23, 2023

The main issue was related to dash/underscore in the container name, see https://docs.docker.com/compose/migrate/#service-container-names.

@tcompa tcompa merged commit d67881c into main Aug 23, 2023
5 checks passed
@tcompa tcompa deleted the pyyaml branch August 23, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin pyyaml version
1 participant