Introduce taskgroupactivityv2 table and /api/v2/task-group-activity/ endpoint #2005

mfranzon · 2024-11-05T09:55:53Z

closes #1972
closes #1976

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I added logging to new code - if appropriate.
I merged main into the current branch.

fractal_server/app/models/v2/task.py

fractal_server/app/routes/api/v2/task_collection.py

fractal_server/tasks/v2/collection_local.py

fractal_server/tasks/v2/utils_background.py

…groupactivityv2-table' into 1972-introduce-taskgroupactivityv2-table

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

fractal_server/app/schemas/v2/task_group.py

fractal_server/app/models/v2/task.py

fractal_server/migrations/versions/57faddb94433_add_taskgroupactivityv2.py

fractal_server/tasks/v2/collection_local.py

fractal_server/tasks/v2/collection_ssh.py

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

[skip ci]

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

github-actions · 2024-11-05T15:01:22Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_server/app/models/v2
__init__.py	$This PR adds 1 to the number of statements in fractal_server/app/models/v2/__init__.py, taking it from 10 to 11.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/models/v2/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/models/v2/__init__.py, which is 100% (11/11).$	$In this PR, 2 new statements are added to fractal_server/app/models/v2/__init__.py, 2 of which are covered (100%).$
task.py	$This PR removes 34 from the number of statements in fractal_server/app/models/v2/task.py, taking it from 63 to 29.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/models/v2/task.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/models/v2/task.py, which is 100% (29/29).$	$This PR does not seem to add statements to fractal_server/app/models/v2/task.py.$
task_group.py	$This PR adds 51 statements to fractal_server/app/models/v2/task_group.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/models/v2/task_group.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/models/v2/task_group.py is 100% (51/51). The file did not seem to exist on the base branch.$	$In this PR, 51 new statements are added to fractal_server/app/models/v2/task_group.py, 51 of which are covered (100%).$
fractal_server/app/routes/admin
v1.py	$This PR removes 9 from the number of statements in fractal_server/app/routes/admin/v1.py, taking it from 180 to 171.$	$This PR removes 1 from the number of statements missing coverage in fractal_server/app/routes/admin/v1.py, taking it from 1 to 0.$	$This PR adds 0.78 percentage points to the coverage rate in fractal_server/app/routes/admin/v1.py, taking it from 99.21% (179/180) to 100% (171/171).$	$In this PR, 1 new statements are added to fractal_server/app/routes/admin/v1.py, 1 of which are covered (100%).$
fractal_server/app/routes/admin/v2
job.py	$This PR removes 9 from the number of statements in fractal_server/app/routes/admin/v2/job.py, taking it from 111 to 102.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/admin/v2/job.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/admin/v2/job.py, which is 100% (102/102).$	$In this PR, 1 new statements are added to fractal_server/app/routes/admin/v2/job.py, 1 of which are covered (100%).$
task_group.py	$This PR adds 23 to the number of statements in fractal_server/app/routes/admin/v2/task_group.py, taking it from 88 to 111.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/admin/v2/task_group.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/admin/v2/task_group.py, which is 100% (111/111).$	$In this PR, 23 new statements are added to fractal_server/app/routes/admin/v2/task_group.py, 23 of which are covered (100%).$
fractal_server/app/routes/api/v2
task_collection.py	$This PR adds 7 to the number of statements in fractal_server/app/routes/api/v2/task_collection.py, taking it from 124 to 131.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/task_collection.py, which is 2.$	$This PR adds 0.06 percentage points to the coverage rate in fractal_server/app/routes/api/v2/task_collection.py, taking it from 98.64% (122/124) to 98.7% (129/131).$	$In this PR, 7 new statements are added to fractal_server/app/routes/api/v2/task_collection.py, 7 of which are covered (100%).$
task_group.py	$This PR adds 39 to the number of statements in fractal_server/app/routes/api/v2/task_group.py, taking it from 77 to 116.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/task_group.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/task_group.py, which is 100% (116/116).$	$In this PR, 39 new statements are added to fractal_server/app/routes/api/v2/task_group.py, 39 of which are covered (100%).$
workflow.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/workflow.py, which is 103.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/workflow.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/workflow.py, which is 100% (103/103).$	$In this PR, 1 new statements are added to fractal_server/app/routes/api/v2/workflow.py, 1 of which are covered (100%).$
workflow_import.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/workflow_import.py, which is 110.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/workflow_import.py, which is 5.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/workflow_import.py, which is 94.11% (105/110).$	$In this PR, 2 new statements are added to fractal_server/app/routes/api/v2/workflow_import.py, 2 of which are covered (100%).$
fractal_server/app/routes/aux
_timestamp.py	$This PR adds 13 statements to fractal_server/app/routes/aux/_timestamp.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/aux/_timestamp.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/aux/_timestamp.py is 100% (13/13). The file did not seem to exist on the base branch.$	$In this PR, 13 new statements are added to fractal_server/app/routes/aux/_timestamp.py, 13 of which are covered (100%).$
fractal_server/app/schemas/v2
__init__.py	$This PR adds 3 to the number of statements in fractal_server/app/schemas/v2/__init__.py, taking it from 46 to 49.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/__init__.py, which is 100% (49/49).$	$In this PR, 3 new statements are added to fractal_server/app/schemas/v2/__init__.py, 3 of which are covered (100%).$
task_collection.py	$This PR adds 9 to the number of statements in fractal_server/app/schemas/v2/task_collection.py, taking it from 104 to 113.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/task_collection.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/task_collection.py, which is 100% (113/113).$	$In this PR, 9 new statements are added to fractal_server/app/schemas/v2/task_collection.py, 9 of which are covered (100%).$
task_group.py	$This PR adds 20 to the number of statements in fractal_server/app/schemas/v2/task_group.py, taking it from 59 to 79.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/task_group.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/task_group.py, which is 100% (79/79).$	$In this PR, 20 new statements are added to fractal_server/app/schemas/v2/task_group.py, 20 of which are covered (100%).$
fractal_server/tasks/v2
collection_local.py	$This PR removes 5 from the number of statements in fractal_server/tasks/v2/collection_local.py, taking it from 129 to 124.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/v2/collection_local.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/tasks/v2/collection_local.py, which is 100% (124/124).$	$In this PR, 6 new statements are added to fractal_server/tasks/v2/collection_local.py, 6 of which are covered (100%).$
collection_ssh.py	$This PR removes 2 from the number of statements in fractal_server/tasks/v2/collection_ssh.py, taking it from 118 to 116.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/v2/collection_ssh.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/tasks/v2/collection_ssh.py, which is 100% (116/116).$	$In this PR, 7 new statements are added to fractal_server/tasks/v2/collection_ssh.py, 7 of which are covered (100%).$
utils_background.py	$This PR adds 14 to the number of statements in fractal_server/tasks/v2/utils_background.py, taking it from 88 to 102.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/v2/utils_background.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/tasks/v2/utils_background.py, which is 100% (102/102).$	$In this PR, 21 new statements are added to fractal_server/tasks/v2/utils_background.py, 21 of which are covered (100%).$
Project Total

_{This report was generated by python-coverage-comment-action}

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

mfranzon added 12 commits November 4, 2024 16:46

add new taskgroupactivityv2 model

eac9846

make redundandancy between taskgroupactivityv2 and collectionstatev2

14375bb

add taskgroupactivity to tests

2818bc6

add migration for taskgroupactivityv2

7223dc1

add taskgroupactivityv2 to collect/pip endpoint

5493a12

add enum for task group activity

9127a30

set fk to none in taskgroupactivityv2 if taskgroup is deleted

ef6efc8

add models

3c05e5b

add enums schemas

6ccd84a

add new update status function

f74778f

add taskgroupactivityv2 to collection ssh

a035356

add new status function for taskgroupactivity

bbbb285

mfranzon linked an issue Nov 5, 2024 that may be closed by this pull request

Introduce TaskGroupActivityV2 table #1972

Closed

ychiucco marked this pull request as draft November 5, 2024 10:00

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/app/models/v2/task.py Outdated Show resolved Hide resolved

new endpoints base

5197717

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/app/routes/api/v2/task_collection.py Outdated Show resolved Hide resolved

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/tasks/v2/collection_local.py Outdated Show resolved Hide resolved

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/tasks/v2/utils_background.py Outdated Show resolved Hide resolved

ychiucco and others added 11 commits November 5, 2024 11:13

read model

fa6758b

get-single endpoint

84bf10b

update taskgroupactivityv2

f96642f

update taskgroupactivityv2 migration

044d454

Merge remote-tracking branch 'refs/remotes/origin/1972-introduce-task…

16bddaa

…groupactivityv2-table' into 1972-introduce-taskgroupactivityv2-table

change attribute name

0d57e86

Merge remote-tracking branch 'refs/remotes/origin/1972-introduce-task…

684b0e2

…groupactivityv2-table' into 1972-introduce-taskgroupactivityv2-table

change attribute name

e4a22be

add taskgroupactivityv2 to collection ssh

f9ea602

update read schema

3de5ca2

replace commit with add

9f0f196

Merge branch '1972-introduce-taskgroupactivityv2-table' of github.com…

ce8e8dd

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/app/schemas/v2/task_group.py Outdated Show resolved Hide resolved

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/app/models/v2/task.py Outdated Show resolved Hide resolved

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/migrations/versions/57faddb94433_add_taskgroupactivityv2.py Outdated Show resolved Hide resolved

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/tasks/v2/collection_local.py Outdated Show resolved Hide resolved

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/tasks/v2/collection_local.py Outdated Show resolved Hide resolved

nullable=False for the timestamp_created

5d1001e

tcompa reviewed Nov 5, 2024

View reviewed changes

fractal_server/tasks/v2/collection_ssh.py Outdated Show resolved Hide resolved

ychiucco and others added 8 commits November 5, 2024 15:35

test get activity list

985bb0c

use Enum in read schema

ec198b1

update migration with nullable false for timestamp_starte; fix tests

beb068a

Merge branch '1972-introduce-taskgroupactivityv2-table' of github.com…

275314d

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

fix timestamp

7233f3a

reorder import

6af7f8b

[skip ci]

use proper function instead assignment

123e6fc

Merge branch '1972-introduce-taskgroupactivityv2-table' of github.com…

1571b86

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

ychiucco and others added 10 commits November 5, 2024 16:22

test admin endpoint

fb986a2

improve coverage

d07fd50

Merge branch '1972-introduce-taskgroupactivityv2-table' of github.com…

37cc3d4

…:fractal-analytics-platform/fractal-server into 1972-introduce-taskgroupactivityv2-table

refactor imports

9ade70b

add new module for taskgroups model

54c1321

fix import

b0ace98

move enum

e4fe182

Merge branch 'main' into 1972-introduce-taskgroupactivityv2-table

def77fe

update changelog

23059e9

[skip ci] add pr number in changelog

09d446b

mfranzon marked this pull request as ready for review November 6, 2024 07:20

tcompa merged commit b8f204c into main Nov 6, 2024

tcompa deleted the 1972-introduce-taskgroupactivityv2-table branch November 6, 2024 07:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce taskgroupactivityv2 table and /api/v2/task-group-activity/ endpoint #2005

Introduce taskgroupactivityv2 table and /api/v2/task-group-activity/ endpoint #2005

mfranzon commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024 •

edited

Loading

Introduce taskgroupactivityv2 table and /api/v2/task-group-activity/ endpoint #2005

Introduce taskgroupactivityv2 table and /api/v2/task-group-activity/ endpoint #2005

Conversation

mfranzon commented Nov 5, 2024 • edited Loading

Checklist before merging

github-actions bot commented Nov 5, 2024 • edited Loading

Coverage report

mfranzon commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024 •

edited

Loading