Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] introduce user settings #1778

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Sep 19, 2024

This is the main branch that will be eventually merged to main.
For the moment we don't merge this PR, but we'll rather open other PRs towards the 1774-introduce-user-settings branch.

Close #1775

Checklist before merging

@tcompa tcompa linked an issue Sep 19, 2024 that may be closed by this pull request
30 tasks
Copy link

github-actions bot commented Sep 19, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.0 9.2 1.20 0.6 0.6
power 388.8 412.1 0.94 389.0 389.0
dataset 148.7 158.5 0.94 145.6 145.6
project 45.8 47.4 0.97 50.9 50.9
job 27.0 26.8 1.01 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 6.2 1.05 2.2 2.2
power 135.1 141.6 0.95 652.0 652.0
dataset 136.7 144.1 0.95 904.8 904.8
project 44.3 49.0 0.90 283.7 283.7
job 38.5 38.9 0.99 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.8 6.7 1.16 0.1 0.1
power 7.7 6.4 1.20 0.1 0.1
dataset 7.6 6.3 1.21 0.1 0.1
project 9.6 8.5 1.13 2.3 2.3
job 7.8 6.5 1.20 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.8 11.4 1.04 0.8 0.8
power 24.1 24.5 0.98 27.2 27.2
dataset 19.4 18.3 1.06 15.8 15.8
project 21.7 21.3 1.02 19.9 19.9
job 11.1 10.0 1.11 0.8 0.8

POST /api/v2/project/3/dataset/418/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 143.9 150.8 0.95 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.0 4.6 1.09 0.2 0.2
power 4.9 4.3 1.14 0.2 0.2
dataset 4.9 4.2 1.17 0.2 0.2
project 4.9 4.3 1.14 0.2 0.2
job 4.9 4.1 1.20 0.2 0.2

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 262.7 263.7 1.00 0.2 0.2

Copy link

github-actions bot commented Sep 19, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  user_settings.py
  fractal_server/app/models
  __init__.py
  security.py
  user_settings.py
  fractal_server/app/routes/api/v2
  _aux_functions.py
  submit.py
  task_collection.py
  fractal_server/app/routes/auth
  _aux_auth.py
  current_user.py
  users.py
  fractal_server/app/routes/aux
  validate_user_settings.py
  fractal_server/app/schemas
  __init__.py
  user_settings.py
  fractal_server/app/security
  __init__.py 219, 308-312
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa mentioned this pull request Sep 19, 2024
ychiucco and others added 25 commits September 19, 2024 11:43
…alidators

Validate sudo-slurm user settings
…f-users-slurm_user-cache_dir-and-slurm_accounts
…f-users-slurm_user-cache_dir-and-slurm_accounts
…f-users-slurm_user-cache_dir-and-slurm_accounts
…te-use-of-users-slurm_user-cache_dir-and-slurm_accounts

Prepare `update-db-script` for v2.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants