Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mathlib to 4.12.0-rc1 #114

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

Parcly-Taxel
Copy link
Contributor

@fpvandoorn I can now report that the Nat.reducePow bug that was causing PANICs in builds of this repo has been fixed.

Copy link
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes which are scope creep. That said, these changes are also fine. LGTM.

@@ -60,8 +60,8 @@ private lemma P'_of_P [BorelSpace X] [ProperSpace X] [IsFiniteMeasureOnCompacts
(coe_nnnorm_ae_le_eLpNormEssSup u μ).mono (by tauto)
apply lt_of_le_of_lt (MeasureTheory.setLIntegral_mono_ae' measurableSet_ball hfg)
rw [MeasureTheory.setLIntegral_const (ball c r) (eLpNormEssSup u μ)]
refine ENNReal.mul_lt_top ?_ (measure_ball_ne_top c r)
exact eLpNorm_exponent_top (f := u) ▸ hu.eLpNorm_lt_top |>.ne
refine ENNReal.mul_lt_top ?_ measure_ball_lt_top
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are very mild golfs: seem innocuous to me.

@fpvandoorn fpvandoorn merged commit 6d3cbe7 into fpvandoorn:master Sep 9, 2024
2 checks passed
@fpvandoorn
Copy link
Owner

Thanks! Next time please update with lake update -Kenv=dev or scripts/update_mathlib.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants