Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: switch lexer and writer to functional options pattern #738

Open
wkalt opened this issue Nov 21, 2022 · 0 comments
Open

go: switch lexer and writer to functional options pattern #738

wkalt opened this issue Nov 21, 2022 · 0 comments
Labels
feature New feature or request go

Comments

@wkalt
Copy link
Contributor

wkalt commented Nov 21, 2022

The current way in which the lexer and writer accept options is clunky. It would be better to use the pattern described here: https://golang.cafe/blog/golang-functional-options-pattern.html. We may also want to supply some options to the Reader implementation in this manner. Currently it takes no options, but would benefit from e.g options to validate CRCs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request go
Development

No branches or pull requests

2 participants