Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: doctor warning on large chunks #731

Open
wkalt opened this issue Nov 17, 2022 · 1 comment
Open

CLI: doctor warning on large chunks #731

wkalt opened this issue Nov 17, 2022 · 1 comment
Labels
cli feature New feature or request

Comments

@wkalt
Copy link
Contributor

wkalt commented Nov 17, 2022

It would be useful if the doctor subcommand printed a warning on large chunks. Going from memory, I think we have used 4MB, 8MB, and 10MB as chunk sizes in various contexts. The warning should be well above those numbers since single oversized messages can create oversized chunks.

50MB would probably be a sufficiently large threshold to trigger primarily in cases where mis-configuration is to blame.

@wkalt wkalt added the feature New feature or request label Nov 17, 2022
@james-rms
Copy link
Collaborator

People can have much larger messages than 50MB, i think it makes sense to only warn if the chunk size gets to some size too big to allocate a single buffer for on certain platforms, say 2**30.

@jtbandes jtbandes added the cli label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli feature New feature or request
Development

No branches or pull requests

3 participants