Skip to content

Commit

Permalink
deps: exclude sshd-sftp
Browse files Browse the repository at this point in the history
The reason for this pr is that the jgit version that is being used
brings in sshd-common (which is brought in by sshd-sftp) which has a
critical security vulnerability attached to it meaning GitHub complains.
You can see the advisory in GHSA-fhw8-8j55-vwgq.

I wasn't sure if I should pin or exclude, but I didn't see anything that
would use this and saw other exclusions, so I figured this was fine.

Note that another way to avoid this would be to bump jgit to the 6.x,
but I understand you don't want to do that as they drop support for Java
8.
  • Loading branch information
ckipp01 committed Dec 8, 2022
1 parent efd9a67 commit 76ab950
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ object Dependencies {
ExclusionRule("org.tukaani", "xz"),
ExclusionRule("junit", "junit")
)
val jgit = "org.eclipse.jgit" % "org.eclipse.jgit" % "5.13.1.202206130422-r"
val jgitSshApache = "org.eclipse.jgit" % "org.eclipse.jgit.ssh.apache" % "5.13.1.202206130422-r"
// We excluded sshd-sftp to avoid https://github.com/advisories/GHSA-fhw8-8j55-vwgq
// Either that or we need to bump to jgit 6.x
val jgit = "org.eclipse.jgit" % "org.eclipse.jgit" % "5.13.1.202206130422-r" excludeAll (
ExclusionRule("org.apache.sshd", "sshd-sftp")
)
val jgitSshApache = "org.eclipse.jgit" % "org.eclipse.jgit.ssh.apache" % "5.13.1.202206130422-r" excludeAll (
ExclusionRule("org.apache.sshd", "sshd-sftp")
)
val scopt = "com.github.scopt" %% "scopt" % "4.1.0"
val scalacheck = "org.scalacheck" %% "scalacheck" % "1.17.0"
val scalatest = "org.scalatest" %% "scalatest" % "3.2.14"
Expand Down

0 comments on commit 76ab950

Please sign in to comment.