Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show label for saving throws roll if exists in @check #16842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reyzor1991
Copy link
Contributor

Text from Message
The target is knocked @UUID[Compendium.pf2e.conditionitems.Item.j91X7x0XSomq8d60]{Prone} unless they succeed at a @Check[fortitude|against:class|name:Hammer Critical Specialization] save against your class DC.

Rigth now name of Check is ignored for saving throws rolls

Message
image

Old roll & New roll
imageimage

@stwlam
Copy link
Collaborator

stwlam commented Oct 17, 2024

Do you have a better example case? In the above, it's more informative that this is the fighter class DC.

@reyzor1991
Copy link
Contributor Author

Example would be very similar because if @Check contains info about against:class it would be post name of class
like Fighter DC, but it also ignore name in check if it exists

@Check[fortitude|against:class|name:Hammer Critical Specialization]

@reyzor1991
Copy link
Contributor Author

Sometime it's more informative like here. One roll vs rune, one vs crit. spec., but if need make 3+ roll and all would contains agains:class, then saving throw message would be similar and need to spend more time to understand which effect apply based on result

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants