Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate player core 2 improvised pummel #15709

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

n1xx1
Copy link
Contributor

@n1xx1 n1xx1 commented Aug 2, 2024

So this is kind of a mess. Probably with some more features in the rule elements (not sure about which ones) it could be improved. The reason it's like this is because I didn't want to write out every single rune, otherwise it would be a nightmare to update every time a new property rune is added.

The handwraps rule elements set some roll options to specify that the actor is using the handwraps (handwraps-of-mighty-blows) and which property runes are filled (handwraps-rune-property0, handwraps-rune-property1, ...). They also add some flags, i.e. potency and striking rune level and the property runes for each slot.

The Improvised Pummel rule elements functions as normal WeaponPotency that uses the max between what the feat gives and what the handwraps give. For the DamageDice it uses either what the feat does or the handwraps striking when improvised-pummel-use-handwraps RollOption is on. Also if the RollOption is on then it also applies the property runes. This should pretty much do exactly what the feat does.

It's a draft because maybe there is a better way to do it with less rule elements, or maybe new predicates that can check the items the actor have?

@n1xx1 n1xx1 force-pushed the feat-automate-improvised-pummel branch from 7ddccc8 to daa4554 Compare August 2, 2024 10:58
@TikaelSol
Copy link
Collaborator

I would much rather opt for a cleaner solution than this

@TikaelSol TikaelSol added the pr: data update Updates to existing actors and items label Aug 2, 2024
@n1xx1
Copy link
Contributor Author

n1xx1 commented Aug 2, 2024

I would much rather opt for a cleaner solution than this

Unfortunately I don't think it's feasible with the current rule elements and predicates. But if you have any suggestions, either as different ways of doing it with existing technology or what features of rule elements might help if implemented, I'm all hears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants