Automate player core 2 improvised pummel #15709
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is kind of a mess. Probably with some more features in the rule elements (not sure about which ones) it could be improved. The reason it's like this is because I didn't want to write out every single rune, otherwise it would be a nightmare to update every time a new property rune is added.
The handwraps rule elements set some roll options to specify that the actor is using the handwraps (
handwraps-of-mighty-blows
) and which property runes are filled (handwraps-rune-property0
,handwraps-rune-property1
, ...). They also add some flags, i.e. potency and striking rune level and the property runes for each slot.The Improvised Pummel rule elements functions as normal WeaponPotency that uses the max between what the feat gives and what the handwraps give. For the DamageDice it uses either what the feat does or the handwraps striking when
improvised-pummel-use-handwraps
RollOption is on. Also if the RollOption is on then it also applies the property runes. This should pretty much do exactly what the feat does.It's a draft because maybe there is a better way to do it with less rule elements, or maybe new predicates that can check the items the actor have?