chore(chisel): enforce common::shell for chisel binary
#9177
+53
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
chisel): enforce common::shell for chisel binarychisel): enforce common::shell for chisel binary
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
yash-atreya
approved these changes
Oct 23, 2024
DaniPopes
approved these changes
Oct 23, 2024
zerosnacks
commented
Oct 23, 2024
| @@ -205,7 +207,7 @@ async fn main_args(args: Chisel) -> eyre::Result<()> { | |||
| } | |||
|
|
|||
| // Print welcome header | |||
| println!("Welcome to Chisel! Type `{}` to show available commands.", "!help".green()); | |||
| sh_println!("Welcome to Chisel! Type `{}` to show available commands.", "!help")?; | |||
There was a problem hiding this comment.
cc @DaniPopes in #9109 you noted messages ought not to be painted in color except for the warn / error keyword, is removing this here correct? Where yellow is used for warnings we use sh_warn!, for red (if an error) we use sh_err! and success (or used in an random way) should not be painted green, correct?
There was a problem hiding this comment.
Yeah but that's for err and warn, and here it's in a REPL too, so it's fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enforces
common::shellas added in #9109 for thechiselbinarySolution
Splits out the enforcement of the common shell per binary / large crate to avoid huge diffs making reviews easier