[RFC] base: ostree: add support systemd-boot automatic boot assesment #1513
Conversation
igoropaniuk
changed the title
| From a9e35b76fd5e47b9bc29a7113d97a4d98a973e75 Mon Sep 17 00:00:00 2001 | ||
| From: Igor Opaniuk <[email protected]> | ||
| Date: Wed, 11 Sep 2024 18:03:10 +0200 | ||
| Subject: [PATCH] Add support systemd-boot automatic boot assesment |
|
Change itself looks ok, is bless boot enabled by default? Just trying to understand if once we land this patch everything will keep working the same way, until we move the confirmation to aktualizr-lite or similar. |
yes, I've tested in on Systemd-boot EFI app handles all |
| represents the amount of maximum tries for boot counting. | ||
|
|
||
| [1] https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/ | ||
| Upstream-Status: Inappropriate [lmp specific] |
There was a problem hiding this comment.
We should probably set as pending here, as this is something we want to try to upstream once there is support for systemd.
|
Shouldn't we be checking if the bootloader used is systemd-boot before appending the counter to the conf file? |
quaresmajose
force-pushed
the
scarthgap-next
branch
from
2db8853
to
27747bc
Compare
Add support for Automatic Boot Assessment [1]. Boot entries are now created with an additional suffix, which represents the amount of maximum tries for boot counting. [1] https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/ Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
bootcount-ostree
branch
from
66ae418
to
5ec9687
Compare
|
@quic-roshs this behavior is described in Bootloader Specification (https://uapi-group.org/specifications/specs/boot_loader_specification/#boot-counting; as well as OSTree also follows it https://ostreedev.github.io/ostree/deployment/#the-system-boot), so this is not systemd-boot specific adjustments |
Is u-boot (uEnv) based boot flows reusing the same code path? |
yes, to create the final uEnv.txt it parses boot entries that were created before (by the function I adjusted in this PR) with |
Add support for Automatic Boot Assessment [1].
Boot entries are now created with an additional suffix, which represents the amount of maximum tries for boot counting.
[1] https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/
Signed-off-by: Igor Opaniuk [email protected]