Cleanup the home directory as it is not preserved by ostree #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCry0
approved these changes
Feb 6, 2024
The user home directory is created in runtime when it does not exist. This will fix the remaining warning: | WARNING: lmp-base-console-image-1.0-r0 do_image_ostree: Data in 'home' directory is not preserved by OSTree. Consider moving it under '/usr' | home/fio | home/fio/.bashrc | home/fio/.profile Signed-off-by: Jose Quaresma <[email protected]>
This will fix the remaining warning: | WARNING: lmp-base-console-image-1.0-r0 do_image_ostree: Data in 'home' directory is not preserved by OSTree. Consider moving it under '/usr' | home/root Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
force-pushed
the
lmp-image-common
branch
from
8316c00
to
c427321
Compare
|
@quaresmajose Could you also include this related commit to your PR? 3699011 |
We don't need to remove the /home directory content anymore because with this PR they should be clean at the end of the image do_rootfs task. In the near future I would like to make this not clean /home and /var a failure, changing the meta-updater OSTREE_RMDIR_HELPER_MSGTYPE to bberror in the helper ostree_rmdir_helper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.