client: Disable compression in default transport #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
similar bug was fix in jobserv UI - foundriesio/gavel-ci@215574a |
vkhoroz
approved these changes
Apr 9, 2024
mike-sul
approved these changes
Apr 9, 2024
The default Golang client will advertise to the HTTP server that it can handle gzip compressed response encoding. This is true, but it breaks our artifacts.go code for doing download progress. This is because the default behavior of the transport is to: * provide the proper reader to decompress the response * update the content-length header to be -1 The -1 breaks our logic. This fix gets us back to how things used to work before CloudFlare started compressing the responses. Signed-off-by: Andy Doan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Golang client will advertise to the HTTP server that it can handle gzip compressed response encoding. This is true, but it breaks our artifacts.go code for doing download progress.
This is because the default behavior of the transport is to:
The -1 breaks our logic. This fix gets us back to how things used to work before CloudFlare started compressing the responses.