offline-update: Add wave target pull support #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
force-pushed
the
offline-update-improvement
branch
from
2fa2ec5
to
3810845
Compare
vkhoroz
reviewed
Feb 5, 2024
doanac
reviewed
Feb 5, 2024
There was a problem hiding this comment.
I see you are moving towards doing error messages with a lowercase first word. eg:
errors.New("this is an error")
This makes the Golang linters happier, but its not how we've traditionally done our other stuff.
I think this is probably fine - we need to stop the bleeding, I suppose. But lets make a conscious decision that this is what we want to do.
Everything else seems pretty good - I'll leave it to @vkhoroz to look close at the new logic
vkhoroz
approved these changes
Feb 6, 2024
vkhoroz
reviewed
Feb 6, 2024
mike-sul
force-pushed
the
offline-update-improvement
branch
2 times, most recently
from
143871c
to
25b6b49
Compare
|
Squashed all "fixup" commits into the single commit. |
- Add ability to download wave's TUF metadata and its target content to the offline update bundle. - Correct checking whether the production target exists for a given tag Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
offline-update-improvement
branch
from
25b6b49
to
c51982c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to download wave's TUF metadata and its target content to the offline update bundle.
Correct checking whether the production target exists for a given tag