Skip to content

Commit

Permalink
Revert "Security: set buildmode to PIE"
Browse files Browse the repository at this point in the history
This reverts commit 6105efe.

It was breaking the Alpine Linux we use to generate docs.
There is something more in play around PIE than expected.
  • Loading branch information
vkhoroz committed Aug 11, 2023
1 parent 8a8948c commit 1bc6d1f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
COMMIT:=$(shell git describe HEAD)$(shell git diff --quiet || echo '+dirty')

# Use linker flags to provide commit info and create a PIE
LDFLAGS=-buildmode=pie -ldflags "-X=github.com/foundriesio/fioctl/subcommands/version.Commit=$(COMMIT)"
# Use linker flags to provide commit info
LDFLAGS=-ldflags "-X=github.com/foundriesio/fioctl/subcommands/version.Commit=$(COMMIT)"

linter:=$(shell which golangci-lint 2>/dev/null || echo $(HOME)/go/bin/golangci-lint)

Expand Down

0 comments on commit 1bc6d1f

Please sign in to comment.