Fix remaining compiler warnings on Windows/MSVC

fougue · Jun 10, 2024 · 64925c4 · 64925c4
1 parent 223fe7b
commit 64925c4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/app/dialog_inspect_xde.cpp b/src/app/dialog_inspect_xde.cpp
@@ -431,8 +431,9 @@ static QTreeWidgetItem* createPropertyTreeItem(const QString& text, const OccHan
     else if (imgTexture->DataBuffer() && !imgTexture->DataBuffer()->IsEmpty()) {
         // Texture is provided by some embedded data
         item->setText(1, DialogInspectXde::tr("<data>"));
-        const OccHandle<NCollection_Buffer>& buff = imgTexture->DataBuffer();
-        item->setImage(1, QByteArray::fromRawData(reinterpret_cast<const char*>(buff->Data()), buff->Size()));
+        const char* buffData = reinterpret_cast<const char*>(imgTexture->DataBuffer()->Data());
+        const int buffSize = Cpp::safeStaticCast<int>(imgTexture->DataBuffer()->Size());
+        item->setImage(1, QByteArray::fromRawData(buffData, buffSize));
     }
 
     return item;

diff --git a/src/base/string_conv.cpp b/src/base/string_conv.cpp
@@ -89,7 +89,7 @@ std::string toUtf8String(std::string_view str, const std::locale& locale)
         return {};
 
     // Encode intermediate utf16 string to utf8
-    const int lenUtf16 = utf16.size() - 1;
+    const int lenUtf16 = Cpp::safeStaticCast<int>(utf16.size()) - 1;
     const int lenUtf8 = WideCharToMultiByte(CP_UTF8, 0, utf16.data(), lenUtf16, nullptr, 0, nullptr, nullptr);
     thread_local std::vector<char> utf8;
     utf8.resize(lenUtf8 + 1);

diff --git a/src/io_ply/miniply.cpp b/src/io_ply/miniply.cpp
@@ -1126,7 +1126,7 @@ namespace miniply {
       return 0;
     }
     const PLYProperty& prop = element()->properties[propIdx];
-    return prop.listData.size() / kPLYPropertySize[uint32_t(prop.type)];
+    return static_cast<uint32_t>(prop.listData.size() / kPLYPropertySize[uint32_t(prop.type)]);
   }