Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI) : Navbar Collapsing Issue #268 #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MananAgr2003
Copy link

Description

Fixed Issue #268 and improved the navbar in the mobile UI.
Fixed Overflow issue in mobile UI.

Relevant ScreenShots :

before :

image

after :

image

@MananAgr2003 MananAgr2003 changed the title MananAgr2003/fix/268 fix(UI) : Navbar Collapsing Issue #268 Dec 18, 2022
@dushimsam
Copy link
Contributor

please squash your commits into one

@MananAgr2003
Copy link
Author

@dushimsam I have squashed the PR kindly review it and merge accordingly.

@soham4abc
Copy link
Contributor

@GMishx @shaheemazmalmmd @Shruti3004 Can you please have a look into this PR?

@@ -0,0 +1,6 @@
@media only screen and (max-width: 550px) {
#footer {
max-width: 102vw;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making its width 102vw will make the footer overflow horizontally.

@Shruti3004
Copy link
Collaborator

Hey @MananAgr2003 please remove the yarn.lock changes from your commit.

@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Apr 18, 2024
Copy link

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has merge conflicts PR has merge conflicts, require rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants