Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (components/widgets/input): Warning while loading delete user page #187

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix (components/widgets/input): Warning while loading delete user page #187

merged 1 commit into from
Jun 13, 2022

Conversation

krishna9304
Copy link
Contributor

Description

This PR is in reference to the issue #167 . A warning in the console stated an error like below,

Warning: Select elements must be either controlled or uncontrolled (specify either the value prop, or the defaultValue prop, but not both). Decide between using a controlled or uncontrolled select element and remove one of these props. More info: https://reactjs.org/link/controlled-components
select

This occurs when we try to use value and defaultValue prop inside a select tag simultaneously.

Changes

The solution is to remove one of the value or defaultValue prop.

Note: This PR also have the fixes for undefined value for currentGroup in local storage

This PR closes #167 .

@krishna9304
Copy link
Contributor Author

krishna9304 commented Mar 22, 2022 •
edited
Loading

@sjha2048 @GMishx @Shruti3004 can you review the PR?

@krishna9304 krishna9304 changed the title Krishna9304/167/warning in delete user page fix (components/widgets/input): Warning while loading delete user page Mar 23, 2022
@krishna9304 krishna9304 mentioned this pull request Mar 28, 2022
Closed
@GMishx GMishx added needs review Need code review needs test Needs testing labels Mar 28, 2022
GMishx
GMishx requested changes Jun 1, 2022
View reviewed changes
src/services/users.js Outdated Show resolved Hide resolved
@krishna9304 krishna9304 force-pushed the krishna9304/167/warning-in-delete-user-page branch 2 times, most recently from 6bdac2a to e5814b6 Compare June 7, 2022 14:10
@krishna9304 krishna9304 force-pushed the krishna9304/167/warning-in-delete-user-page branch from e5814b6 to c0a86e0 Compare June 7, 2022 15:20
@krishna9304 krishna9304 requested a review from GMishx June 7, 2022 15:27
GMishx
GMishx approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Needs test.

@GMishx GMishx removed the needs review Need code review label Jun 13, 2022
GMishx
GMishx approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready PR is ready for merge and removed needs test Needs testing labels Jun 13, 2022
@GMishx GMishx merged commit bd5afd9 into fossology:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
ready PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning while loading delete user page
3 participants
@krishna9304 @GMishx @krishna1742