added useAlert hook to display danger and success alerts #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
requested changes
Mar 21, 2022
There was a problem hiding this comment.
Please update the commit message in accordance to our contributing guidelines.
| @@ -0,0 +1,112 @@ | |||
| import React, { | |||
There was a problem hiding this comment.
Please add appropriate license and copyright header.
There was a problem hiding this comment.
Sorry for messing up this pull request. I have made the requested changes in a new pull request kindly review it. #186
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
…dropdown Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Import errMsg from constants in sendRequest.js Import errMsg from constants in UploadReuse Import errMsg from constants to ErrorPage Rename constants file errorMessages to messages The constants file is supposed to include all message types, so I have renamed the constants file to reflect this. I have also changed the name of the errMsg object to messages. Import messages into Group\Create Import messages into Delete Import messages into Browse Import messages into ScheduleAgents Import messages into Create Import messages into Delete Import messages into Edit Import messages into Move Import messages into Unlink Import messages into License/Create Import messages into Upload/Delete Import messages into Uploads/Move Import messages into Upload/File Import messages into Upload/Url Import messages into Upload/Vcs Add Stevie Gill's email to messages.js Text changes in messages to improve consistency Removed full points and capital letters from some of the strings to improve the consistency of the messages.
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Signed-off-by: Shruti3004 <[email protected]>
Added copy code block on yarn commands and made that section look better Signed-off-by: Devesh <[email protected]>
github-actions
bot
added
the
has merge conflicts
|
This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to the issues
#157
#155
#154
Description
useAlert hook to display success and danger snackbars. The alert message disappears after 5 seconds or if the user closes the alert message.
Changes
Added an AlertProvider component that provides a useAlert() hook which uses react context under the hood. The hook returns a function alertUser(message,type) which accepts message and type as parameters.
Implementation
The alertUser() is implemented in Pages>Home>index.jsx at line 80 and 88. Other Alerts can be changed to use hooks as well (will do it after the code is reviewed).
Snackbar.mp4