Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bottomBar Slide Animation #2925

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Fixed bottomBar Slide Animation #2925

wants to merge 7 commits into from

Conversation

satyajiit
Copy link

Fixed #2923

Changes: Added a global variable to MyApplication Class.
And applied transition based on logic/conditions to each of the three activities.
Since we have three NavItems NavItem starts from zero to two.
Added four new anim xml files and deleted the old two.

GIF :
gif

Thank you @codedsun for your valuable feedback and review on this issue. 🙂

Fixed Image Delete Issue , TrashBin Issue and More

Clicking on Delete Icon on the Toolbar now deletes all the images.
Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id.
Fixed an issue in which files are not deleted from ".nomedia" directory.
Also Updated some external library versions.

Fixed Image Delete Issue , TrashBin Issue and More

Clicking on Delete Icon on the Toolbar now deletes all the images.
Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id.
Fixed an issue in which files are not deleted from ".nomedia" directory.
Also Updated some external library versions.

Update build.gradle

Origin
Copy link

@rob729 rob729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satyajiit Squash these commits into a single commit

@satyajiit
Copy link
Author

@rob729 is it fine now?
Or should i start a new PR?

Copy link
Contributor

@codedsun codedsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use base activity instead of application class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom menu bar "move in effect" not from expected direction
6 participants