Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .gitattributes file for EOL normalization #961

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Aug 6, 2023

  • add .gitattributes for non-vscode editors
  • replace single with double quotes (and escape them) in the prettier call to be shell-agnostic.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #961 (071a160) into main (7ec3798) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          12       12           
  Lines        2305     2305           
  Branches      205      205           
=======================================
  Hits         1927     1927           
  Misses        373      373           
  Partials        5        5           

@michaelkonecny
Copy link

The escaped double quotes work fine, thank you.

As for .gitattributes, you need to add another line:

* eol=lf

for it to work.

After that, everything seems to work fine - the repo gets checked out with LFs even though core.autocrlf=true and vscode correctly detects the files having LF and works with them in this mode, so no need to set anything there.

@gnikit
Copy link
Member Author

gnikit commented Aug 6, 2023

@michaelkonecny awesome, I will add it and merge. Please do not about my comment on the now closed PR #955, all scripts in package.json using && will not work in powershell.

@gnikit gnikit merged commit 1635716 into main Aug 6, 2023
4 checks passed
@gnikit gnikit deleted the chore/gitattributes branch August 6, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants