-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change in structure of stdlib in order to compiler it using fypp script #675
base: master
Are you sure you want to change the base?
Conversation
To solve the issues, the following should be done:
|
Did you also solve the issues with:
|
For |
Than you also have to remove the declaration of the tests from the CMake build files. |
Should I change the include path of |
No, I don't think so. Instead the variable ...
fyflags="${fyglags} -I include"
... |
auto-examples = false | ||
auto-tests = true | ||
|
||
[preprocess.cpp] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be
[preprocess.cpp] | |
[preprocess.fypp] |
?
As far as I remember, CPP is not used within stdlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is not used. But, we have not enabled fypp
inside fpm
as of now. So, it cannot identity it as a valid preprocessor. Considering fypp-gfortran.py
as a temporary solution, I think when we have fypp
integrated inside fpm then I think we should rename it as fypp instead of cpp.
To solve the issue with the |
Hi @jvdp1, I still seem to face some issues with docs ci. Can you help me in resolving this? |
This should be related to the version update of FORD, see #673 . |
@arteevraina Indeed it seems to be related to #673 |
@arteevraina Could you rebase your PR such that @zoziha chnages (#681) are also integrated into this PR, please? |
This reverts commit 16d8b86.
6269e49
to
7c99e70
Compare
"PROJECT_VERSION_MAJOR=0", | ||
"PROJECT_VERSION_MINOR=1", | ||
"PROJECT_VERSION_PATCH=0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we support extracting those values automatically in fpm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should add support to extract them for the version number ?
I will take up this task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR created for this fortran-lang/fpm#766
```sh | ||
git clone https://github.com/fortran-lang/fpm.git | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that provided? IMO a link to fpm
should be sufficient.
This Pull Request makes few structural changes in
stdlib
to make get it compiled using the compiler wrapper script here.