-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mac/lfortran): only install micromamba if needed #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wpbonelli
commented
Mar 27, 2024
- followup to Add LFortran Compiler Support #57
iulusoy
added a commit
to ssciwr/setup-fortran
that referenced
this pull request
Apr 9, 2024
* fix(mac/lfortran): only install micromamba if needed (fortran-lang#79) * docs(readme): mention lfortran in compiler option section (fortran-lang#80) * ci: include long_compat.csv in autoupdate prs (fortran-lang#85) * Update compatibility matrix (fortran-lang#86) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor(gcc): drop support for gcc 7 and 8 (fortran-lang#83) These have patchy availability. And anyways, the oldest release series still receiving support is 11, so there may be an argument for dropping 9 and 10, but I will leave that for later. In any case, nothing prevents trying unsupported versions, but we will no longer test them or make guarantees. This frees up room in the test matrix, which is capped at 256 jobs * feat(intel): support intel 2024.1 on linux and windows (fortran-lang#84) --------- Co-authored-by: wpbonelli <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
iulusoy
added a commit
to ssciwr/setup-fortran
that referenced
this pull request
Jun 11, 2024
* fix(mac/lfortran): only install micromamba if needed (fortran-lang#79) * docs(readme): mention lfortran in compiler option section (fortran-lang#80) * ci: include long_compat.csv in autoupdate prs (fortran-lang#85) * Update compatibility matrix (fortran-lang#86) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor(gcc): drop support for gcc 7 and 8 (fortran-lang#83) These have patchy availability. And anyways, the oldest release series still receiving support is 11, so there may be an argument for dropping 9 and 10, but I will leave that for later. In any case, nothing prevents trying unsupported versions, but we will no longer test them or make guarantees. This frees up room in the test matrix, which is capped at 256 jobs * feat(intel): support intel 2024.1 on linux and windows (fortran-lang#84) --------- Co-authored-by: wpbonelli <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
iulusoy
added a commit
to ssciwr/setup-fortran
that referenced
this pull request
Jun 11, 2024
* fix(mac/gcc): just brew install --force (fortran-lang#96) * fix(intel-classic): fix recent ifort versions on linux and windows (fortran-lang#93) Co-authored-by: wpbonelli <[email protected]> * Update action.yml * Update compatibility matrix (#3) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compatibility matrix (#2) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * V0 (#4) * add version number to apt mkl install * hpc basekit for macos * fix failing macos tests (#6) * info-on-mac * set mkl version explicitly * more debug on mac * fix variable typo for linux mkl version * only test on ubuntu * matrix * matrix * fix version selection * check both classic and new * verify dmg * check hpckit * check hpckit * restrict basekit versions * pass install_mkl and test mkl * set input in main action * set input in main action * set input in script * fix typo * change linker options * source env * export DYLD path for Mac * include explicit library path in linker * export mklroot in script * export mklroot to GH env * export mklroot to GH env * export mklroot in script * correct typo * another typo * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * debug env vars * typo and relative reference mklroot * debug mklroot path * debug mklroot path * typo * find include dir * find include dir * debug mac os dyld path * check all ubuntu * no mkl for gcc and nvidia-hpc * mkl lates * check compiler vars * mkl dir for macos * debug * debug * adapt test structure * remove double testing * conditional in bash * conditional in bash * conditional in bash * conditional in bash * typo * pass missing variable * test them all * test them all * check macos mkl path * set full library path in script * export DYLD in env * test them all * exclude mkl tests on windows * exclude mkl tests on windows * check for dyld * rename mkllib in gh env * shuffle version mapping for mac * export DYLD in script * shuffle mkl version numbers * find installed mkl version * try without mkl * try without mkl * find installed mkl version * find installed mkl version * shuffle mkl vs ifort version * find mkl for 2021.5 * skip mkl for 2021.5 macos and remove double export of dyld * less chatty, .5 exception * last changes? * test 2021.5 only * test them all * export dyld in action * Check usage of marketplace action (#7) * correct passsing of include_mkl in example * don't source intel set vars * run setvars, set MKLLIB * Sync fork (#8) * feat: set FPM environment variables (fortran-lang#63) * set FPM_FC/FPM_CC/FPM_CXX matching FC/CC/CXX * consolidate env var assignment in setup script * feat: support intel 2024.0 on linux and windows (fortran-lang#64) * fix(mac/gcc): always create unversioned gcc/g++/gfortran links (fortran-lang#65) * brew doesn't link gcc/g++ without version number like it does for gfortran * this was causing default mac gcc/g++ to be discovered on PATH * fix readme auto-update PR conditionals in reporting mode * Update compatibility matrix (fortran-lang#66) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * ci: don't trigger when tags are pushed (fortran-lang#67) * correct typo * fix variable name * pass cpp_name * pass cpp_name --------- Co-authored-by: wpbonelli <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Create pr and sync (#10) * removed source setvars and manipulation of DYLD_LIBRARY_PATH move macos mkl install into separate script move variable export to main calling function set lib env export in action source instead of execute set MKLLIB per case, skip 2021.5 macos mkl * use macos install script for both dmgs, answer y in apt install for act compatibility * remove accidental duplication * reverse order of passed variables in case string is empty * remove pasted garbage in link * rename macos install script * try wo another export of MKLLIB in the action.yml * export mkllib in test * no latest when using MKLROOT for macos * test for macos 14 with latest basekit for all intel comp versions * set conditions to run mkl test in mkl action file * run all tests * exclude lfortran and nvidia from mkl test * include math branch in test trigger (#15) * Sync fork (#19) * fix(mac/lfortran): only install micromamba if needed (fortran-lang#79) * docs(readme): mention lfortran in compiler option section (fortran-lang#80) * ci: include long_compat.csv in autoupdate prs (fortran-lang#85) * Update compatibility matrix (fortran-lang#86) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor(gcc): drop support for gcc 7 and 8 (fortran-lang#83) These have patchy availability. And anyways, the oldest release series still receiving support is 11, so there may be an argument for dropping 9 and 10, but I will leave that for later. In any case, nothing prevents trying unsupported versions, but we will no longer test them or make guarantees. This frees up room in the test matrix, which is capped at 256 jobs * feat(intel): support intel 2024.1 on linux and windows (fortran-lang#84) --------- Co-authored-by: wpbonelli <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compatibility matrix (#20) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * merge changes (#22) * Update compatibility matrix (#26) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * rename action in readme --------- Co-authored-by: wpbonelli <[email protected]> Co-authored-by: Alexis Montoison <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.