Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem_utilities.c: use INODE64 on 64-bit, but not on 32-bit #997

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

barracuda156
Copy link
Contributor

Closes: #993

  1. I have tested fpm on i386 with this fix, it seems to work just fine (like it does on 32-bit ppc). I tried to build several ports that use fpm, everything worked as expected. (Without this it is just broken: there is no _opendir$INODE64 for i386.)
  2. While I cannot test anything on ppc64 at the moment, the symbol is in fact available in libSystem for this arch, so presumably we do not need to disable this chunk there. (__POWERPC__ is defined for ppc and ppc64 both, while __ppc__ – only for ppc.)

Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a way to test it but I'm guessing it works of course. Thanks for sharing @barracuda156, LGTM.

@barracuda156
Copy link
Contributor Author

@perazz I guess we should be good to merge this. I won’t be able to deal with ppc64 testing soon (though I will do it eventually), but from what it looks, this should work there too. ppc is left as-is (changing the macro is inconsequential for it), i386 will be fixed by this.

@awvwgk awvwgk merged commit 168ab68 into fortran-lang:main Feb 18, 2024
23 checks passed
@barracuda156 barracuda156 deleted the inode64 branch February 18, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i386] Build error: Undefined symbols for architecture i386: "_opendir$INODE64"
3 participants