Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear registry cache using fpm clean --registry-cache #949

Merged
merged 6 commits into from
Mar 23, 2024

Conversation

minhqdao
Copy link
Contributor

@minhqdao minhqdao commented Jun 22, 2023

  • Clear registry cache using the --registry-cache command option for fpm clean.
  • Add tests for --registry-cache, --skip and --all.
  • Throw error if --skip and --all are used simultaneously.
  • Fix typo clean_call --> clean_all.
  • Add to fpm help.

Things to discuss

  • The rm -rf <registry-cache> command is executed no matter if the folder exists or not. This isn't problematic. But we could warn the user if the folder doesn't exist, consistent to what happens when the user tries to remove the build folder if it doesn't exist.
  • One could additionally ask the user to confirm the deletion of the registry cache because it potentially affects all projects on the system.

How to test

  • Run fpm run -- clean --registry-cache.
  • Use in conjunction with --skip and --all options.

Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minhqdao, Looks good to me.

@henilp105
Copy link
Member

Thanks @perazz @minhqdao , Looks good to me , Will merge in a few hours for the new fpm release.

@henilp105
Copy link
Member

Merging!

@henilp105 henilp105 merged commit 6bf8c23 into main Mar 23, 2024
32 checks passed
@henilp105 henilp105 deleted the clean-registry-cache branch March 23, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants