Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fpm_model.json to the package tarball before uploading to the registry #1010

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

henilp105
Copy link
Member

This PR introduces a bug fix to attach a fpm_model.json file , this bug has been patched in an interim manner in the registry repo: fortran-lang/registry#75 .

Thanks and Regards,
Henil

@henilp105 henilp105 requested review from perazz and gnikit March 24, 2024 17:55
@gnikit
Copy link
Member

gnikit commented Mar 25, 2024

@henilp105 does this affect any other fpm activity? As in, do we call git_archive in any a context other than the registry integration at the moment?

@henilp105
Copy link
Member Author

henilp105 commented Mar 25, 2024

@gnikit No, The git_archive functionality is only used to publish a tarball to the registry. This bug doesn't affect any other fpm functionality. the tarball uploaded on the registry must contain a fpm_model.json file, which was not getting attached in v0.10.1 to handle this in an interim manner a patch fortran-lang/registry#75 has been made on the registry side to generate and attach the fpm_model.json file to the tarball on the server side, This is a permanent fix for the bug.

@perazz
Copy link
Contributor

perazz commented Mar 25, 2024

My edit reflects @gnikit (and my) concern to not lose the option to call git_archive from elsewhere. LGTM with this edit, let's see what Giannis thinks.

@henilp105
Copy link
Member Author

Thanks @perazz for fixing this.

@henilp105 henilp105 changed the title fix: add fpm_model.json to the package tarball before uploading to this registry. fix: add fpm_model.json to the package tarball before uploading to the registry Mar 25, 2024
@gnikit gnikit merged commit 07fce84 into fortran-lang:main Mar 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants