Group 5: Refactoring #22
Open
+43
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,7 @@ void thenTheBookingShouldBeStopped() throws NoSuchFieldException { | |||
| ScheduledFlight scheduledFlight = schedule.searchScheduledFlight(flight.getNumber()); | |||
| assertThrows(IllegalStateException.class, () -> customer.createOrder(Arrays.asList("Amanda", "Max"), Arrays.asList(scheduledFlight), 180)); | |||
| assertEquals(3, scheduledFlight.getPassengers().size()); | |||
| assertEquals(4, scheduledFlight.getCapacity()); | |||
There was a problem hiding this comment.
after the presentation today, I would prefer the old solution here :)
| @@ -30,19 +31,6 @@ public ScheduledFlight(int number, Airport departure, Airport arrival, Identifie | |||
| this.currentPrice = currentPrice; | |||
| } | |||
|
|
|||
| public int getCrewMemberCapacity() throws NoSuchFieldException { | |||
There was a problem hiding this comment.
i would keep the function but call the method of aircraft
| } else if (this.aircraft instanceof Helicopter) { | ||
| model = ((Helicopter) this.aircraft).getModel(); | ||
| } else if (this.aircraft instanceof PassengerDrone) { | ||
| model = "HypaHype"; | ||
| } else { | ||
| throw new IllegalArgumentException(String.format("Aircraft is not recognized")); |
There was a problem hiding this comment.
this could be a separate commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of class hierarchy for aircrafts and according changes in other classes