Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct underline color for validated textfiled #196

Merged
merged 1 commit into from
Jul 18, 2017
Merged

correct underline color for validated textfiled #196

merged 1 commit into from
Jul 18, 2017

Conversation

dex157
Copy link
Contributor

@dex157 dex157 commented Feb 16, 2017 •
edited
Loading

@dex157 dex157 changed the title correct color for validated underline correct underline color for validated textfiled Feb 16, 2017
@cryptokoala4
Copy link

+1

@dex157
Copy link
Contributor Author

dex157 commented Feb 20, 2017

@mbrookes what you think about this pr?

ryanblakeley
ryanblakeley reviewed Feb 20, 2017
View reviewed changes
Copy link
Collaborator

@ryanblakeley ryanblakeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a better implementation for getting the default validationColor. Can anyone vouch that this plays nicely with a custom theme provider? and it works throughout the validation life cycle: untouched/valid/invalid..?

@cryptokoala4
Copy link

Can we get this pushed into release? It works fine on react-boiler-plate

@connorkuehnle
Copy link

Can this get merged into master please?

@ryanblakeley ryanblakeley merged commit ea408ef into formsy:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanblakeley ryanblakeley ryanblakeley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dex157 @cryptokoala4 @connorkuehnle @ryanblakeley