Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code refactoring and features added - Sammya Majumdar #332

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

majumdarSammya
Copy link

@majumdarSammya majumdarSammya commented Aug 16, 2023

Features added:

  1. Money transfer between accounts.
  2. Changed MAXI_SAVER_ACCOUNT interest rate based on no withdrawals in the last 10 days.

Refactoring:

  1. Changed path of DateProvider and DateChecker class to DateUtils folder.
  2. Path of TransferService class to TransferServiceUtils folder.
  3. Test cases for DateChecker is under DateUtilsTests folder inside test.
  4. Test cases for TransferService class is under TransferServiceUtilsTest folder inside test.
  5. Broken up interestEarned method into 3 methods each for a different account type.

Misc changes:

  1. Interest rates are assigned to constants.
  2. Renamed total account balance method to getAccountBalance.
  3. Added new methods to return account type and transaction list inside Account class.
  4. Corrected getFirstCustomer method inside Bank class.
  5. Added isAfter method to check date inside Transaction class.
  6. Added public methods to access transaction amount and transaction date inside Transaction class.
  7. Added if-else statement inside totalInterestEarned method inside Customer class.
  8. Modified test case method names inside BankTest.java to better reflect the purpose of the test cases.
  9. Modified testing totalInterestPaid method logic to reflect the original logic of the method - total interest paid across accounts to different customers.
  10. Added AccountTest class to test methods inside Account class.
  11. Added test case to check getName method.
  12. Added 3 new test cases under TransactionTest.java to test three new methods added.
  13. Added DateCheckerTest inside DateUtilsTests to test hasTransactionWithinLastTenDays and IsWithinLastTenDays method.
  14. MoneyTransferTest is under TransferServiceUtils Test to check transfer between two accounts.
  15. Added Javadoc comments to all methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant