Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the rationale for [transformed components FAIL] if a font is not hinted with ttfa? #3966

Closed
felipesanches opened this issue Nov 29, 2022 · 1 comment
Closed

What is the rationale for [transformed components FAIL] if a font is not hinted with ttfa? #3966

felipesanches opened this issue Nov 29, 2022 · 1 comment
Milestone
Leftover from lat...

Comments

@felipesanches
Copy link
Collaborator

felipesanches commented Nov 29, 2022 •
edited
Loading

What is the rationale for this fail if a font is not hinted with ttfa?
It looks like this landed in universal and we are now failing on unhinted TT font builds.

Originally posted by @chrissimpkins in #2011 (comment)
@felipesanches felipesanches added this to the 0.8.11 milestone Nov 29, 2022
josh-hadley added a commit to josh-hadley/fontbakery that referenced this issue Dec 6, 2022
@josh-hadley
exclude com.google.fonts/check/transformed_components from adobefonts
365c633 
- test seems inappropriate for some cases (e.g. unhinted VFs), see fonttools#3966
- update expected number of tests in adobefonts_test.py:: test_profile_check_set
josh-hadley added a commit to josh-hadley/fontbakery that referenced this issue Dec 6, 2022
@josh-hadley
exclude com.google.fonts/check/transformed_components from adobefonts
12cf485 
- test seems inappropriate for some cases (e.g. unhinted VFs), see fonttools#3966
- update expected number of tests in adobefonts_test.py:: test_profile_check_set
miguelsousa pushed a commit that referenced this issue Dec 6, 2022
@josh-hadley @miguelsousa
exclude com.google.fonts/check/transformed_components from adobefonts
642c48b 
- test seems inappropriate for some cases (e.g. unhinted VFs), see #3966
- update expected number of tests in adobefonts_test.py:: test_profile_check_set
@felipesanches felipesanches modified the milestones: 0.8.11, 0.8.12 Mar 3, 2023
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.14 Jun 2, 2023
@simoncozens
Copy link
Collaborator

Merging with #4024.

@simoncozens simoncozens closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Leftover from latest dev-cycle
Development

No branches or pull requests
2 participants
@simoncozens @felipesanches