Update VSCode webview proxy

.github/FUNDING.yml

@@ -0,0 +1 @@
+open_collective: julialang

.github/ISSUE_TEMPLATE/bug_report.md

@@ -9,9 +9,10 @@ assignees: ''
 
 Thank you for reporting an issue about Pluto! Let's get it fixed!
 
-# To report an issue, you need two things:
+# To report an issue, you need three things:
 1. 📹 A video recording demonstrating the problem. (You can drag a video file into this box)
 2. 📝 A short Pluto notebook file. (Upload the notebook file to https://gist.github.com/ and include the link.)
+3. 🤕 Try to clearly explain what the problem is, it might not be obvious to others! Instead of saying: "This does not work.", try to say: "I expected ..., but instead I am seeing ..."
 
 
 🙋 But my issue is really simple, I don't want to make a screen recording / notebook!

.github/workflows/Bundle.yml

@@ -5,45 +5,74 @@ on:
         branches:
             - main
     workflow_dispatch:
+    pull_request:
+        paths-ignore:
+            - "**.md"
+            - "**.jl"
+        branches-ignore:
+            - release
+
+concurrency:
+    group: bundle-${{ github.ref }}
+    cancel-in-progress: false
 
 jobs:
     trigger:
         runs-on: ubuntu-latest
         steps:
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v3
               # We use that PAT token instead of GITHUB_TOKEN because we are triggering another github action on the 'release' event.
               # Triggering a workflow from a workflow is only allowed if the relaying event is signed with a PAT.
               # See https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token
               with:
                 token: ${{ secrets.PAT_TOKEN }}
+              if: github.event_name != 'pull_request'
+
             - uses: fregante/setup-git-user@v1
-
+              if: github.event_name != 'pull_request'
+
             # Ignore the build changes from previous run.
             # This "just" hard resets to the latest commit on main.
             # The previous bundle commit will still exist, but will be "dangling", unless we made a tag for it.
             # Github will eventually clean dangling commits, which is fine because again, the ones with a tag will stay around.
             - name: Make Sure Release Is Reset To Main
+              if: github.event_name != 'pull_request'
               run: |
                   git checkout -b release
                   git reset --hard $GITHUB_SHA
 
+            # if this is a PR. then just checkout without fanciness
+            - uses: actions/checkout@v3
+              if: github.event_name == 'pull_request'
+
             # Do the actual bundling
-            - uses: actions/setup-node@v2
+            - uses: actions/setup-node@v3
               with:
                   node-version: 17.x
                   cache: "npm"
                   cache-dependency-path: frontend-bundler/package-lock.json
+
             - run: npm install
               working-directory: frontend-bundler
-            - name: The Actual Build
+
+            - name: The Actual Build (try 3 times)
               working-directory: frontend-bundler
-              run: npm run build
+              run: |
+                (npm run build) || (npm run build) || (npm run build)
+
+            - name: Check for corrupt files
+              working-directory: frontend-dist
+              run: |
+                if [[ $(find . -empty) ]]; then
+                    exit 1
+                fi
 
             # Push the rebuild frontend-dist to the release branch.
             # Needs to be `add --force` because frontend-dist is normally gitignored.
             # Also needs `push --force` because we reset to main (which doesn't contain the previous frontend-dist)
             - name: Force push frontend-dist changes
+              if: github.event_name != 'pull_request'
               run: |
                   git add frontend-dist --force
-                  git commit -m "$GITHUB_WORKFLOW"
+                  git commit -m "$GITHUB_WORKFLOW" -m "Built from hash $GITHUB_SHA"
                   git push origin release --force

.github/workflows/FrontendTest.yml

@@ -19,23 +19,24 @@ on:
 jobs:
     frontend-test:
         runs-on: "ubuntu-latest"
+        timeout-minutes: 30
 
         steps:
             # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v3
 
             # Makes thes `julia` command available
             - uses: julia-actions/setup-julia@v1
               with:
-                  version: "1.5"
+                  version: "1.6" # our lowest supported version
 
             - name: Install Pluto.jl packages
               run: |
                   julia --project=$GITHUB_WORKSPACE -e "using Pkg; Pkg.instantiate()"
 
-            - uses: actions/setup-node@v1
+            - uses: actions/setup-node@v3
               with:
-                  node-version: "12.x"
+                  node-version: "18.x"
 
             - name: Install Chrome dependencies
               run: |
@@ -62,24 +63,27 @@ jobs:
             - name: Run tests
               working-directory: ./test/frontend
               run: |
-                  julia -e "import Pkg; Pkg.add(path=\"$GITHUB_WORKSPACE\"); Pkg.instantiate(); import Pluto; Pluto.run(port=$PLUTO_PORT, require_secret_for_access=false)" & # Run Pluto.jl server in the background
+                julia --project=$GITHUB_WORKSPACE -e 'import Pluto
+                  # Run Pluto.jl server in the background
+                  options = Pluto.Configuration.from_flat_kwargs(; 
+                    port=parse(Int, ENV["PLUTO_PORT"]), 
+                    require_secret_for_access=false,
+                    workspace_use_distributed_stdlib=false,
+                  )
+                  🍭 = Pluto.ServerSession(; options)
+                  server = Pluto.run!(🍭)
 
-                  # Wait for Pluto to initialize
-                  TIMES_TRIED=0
-                  until [ $TIMES_TRIED -eq 60 ] || $(curl --output /dev/null --silent --fail "http://localhost:$PLUTO_PORT/"); do
-                      printf '.'
-                      TIMES_TRIED=$((TIMES_TRIED+1))
-                      sleep 1
-                  done
+                  run(`npm run test`)
+
+                  close(server)'
 
-                  npm run test
               env:
                   PLUTO_PORT: 1235
                   PLUTO_TEST_OFFLINE: ${{ github.ref_name == 'release' }}
                   PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: "true"
                   PUPPETEER_EXECUTABLE_PATH: "/usr/bin/google-chrome-stable"
 
-            - uses: actions/upload-artifact@v2
+            - uses: actions/upload-artifact@v3
               if: failure()
               with:
                   name: test-screenshot-artifacts

.github/workflows/IntegrationTest.yml

@@ -0,0 +1,69 @@
+name: Test dependent packages
+
+# based on https://github.com/SciML/SciMLBase.jl/blob/master/.github/workflows/Downstream.yml, thanks!
+
+# this is the same as Test.yml
+on:
+    workflow_dispatch:
+    push:
+        paths-ignore:
+            - 'frontend/**'
+            - 'frontend-bundler/**'
+            - 'frontend-dist/**'
+            - 'test/frontend/**'
+            - '**.md'
+        branches:
+            - main
+    pull_request:
+        paths-ignore:
+            - 'frontend/**'
+            - 'frontend-bundler/**'
+            - 'frontend-dist/**'
+            - 'test/frontend/**'
+            - '**.md'
+        branches-ignore:
+            - release
+
+
+jobs:
+    test:
+        name: ${{ matrix.package.repo }}
+        runs-on: ${{ matrix.os }}
+        strategy:
+            fail-fast: false
+            matrix:
+                julia-version: [1]
+                os: [ubuntu-latest]
+                package:
+                    - { user: JuliaPluto, repo: PlutoSliderServer.jl }
+
+        steps:
+            - uses: actions/checkout@v3
+            - uses: julia-actions/setup-julia@v1
+              with:
+                  version: ${{ matrix.julia-version }}
+                  arch: x64
+            - uses: julia-actions/julia-buildpkg@v1
+            - name: Clone Downstream
+              uses: actions/checkout@v3
+              with:
+                  repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
+                  path: downstream
+            - name: Load this and run the downstream tests
+              shell: julia --project=downstream {0}
+              run: |
+                  using Pkg
+                  try
+                    # force it to use this PR's version of the package
+                    Pkg.develop(PackageSpec(path="."))  # resolver may fail with main deps
+                    Pkg.update()
+                    Pkg.test()  # resolver may fail with test time deps 
+                  catch err
+                    err isa Pkg.Resolve.ResolverError || rethrow()
+                    # If we can't resolve that means this is incompatible by SemVer and this is fine
+                    # It means we marked this as a breaking change, so we don't need to worry about
+                    # Mistakenly introducing a breaking change, as we have intentionally made one
+
+                    @info "Not compatible with this release. No problem." exception=err
+                    exit(0)  # Exit immediately, as a success
+                  end

.github/workflows/LaunchTest.yml

@@ -13,12 +13,12 @@ jobs:
         strategy:
             matrix:
                 # We test quite a lot of versions because we do some OS and version specific things unfortunately
-                julia-version: ["1.0", "1.5", "1.7"]
+                julia-version: ["1.6", "1.7"]
                 os: [windows-latest, ubuntu-latest]
 
         steps:
             # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v3
 
             # Makes thes `julia` command available
             - uses: julia-actions/setup-julia@v1

.github/workflows/ReleaseTriggers.yml

@@ -14,7 +14,7 @@ jobs:
       matrix:
         repository: ['fonsp/pluto-on-binder', 'JuliaPluto/sample-notebook-previews']
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - run: |
           curl \
             -X POST \

.github/workflows/TagBot.yml

@@ -23,17 +23,11 @@ jobs:
                   # See https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token
                   token: ${{ secrets.PAT_TOKEN }}
                   changelog: |
-                    ## {{ package }} {{ version }}
-
-                    > Try this release in your browser! _(Available 30 minutes after the release)_
+                    > **Try this release in your browser!** _(Available 30 minutes after the release)_
                     > 
                     > <a href="https://binder.plutojl.org/{{ version }}/"><img alt="Binder logo" src="https://mybinder.org/badge_logo.svg"></a>
-
-                    **Generate your own binder links using [pluto-on-binder.glitch.me](https://pluto-on-binder.glitch.me/)!**
-
-                    {% if previous_release %}
-                    [Diff since {{ previous_release }}]({{ compare_url }})
-                    {% endif %}
+                    >
+                    > Generate your own binder links using [pluto-on-binder.glitch.me](https://pluto-on-binder.glitch.me/)!
 
                     {% if custom %}
                     {{ custom }}
@@ -52,3 +46,19 @@ jobs:
                     - {{ issue.title }} (#{{ issue.number }})
                     {% endfor %}
                     {% endif %}
+
+                    # New features
+                    *(TODO)*
+
+                    # Performance improvements
+                    *(TODO)*
+
+                    # Fixes
+                    *(TODO)*
+
+                    # Internal changes
+                    *(TODO)*
+
+                    {% if previous_release %}
+                    [Diff since {{ previous_release }}]({{ compare_url }})
+                    {% endif %}

.github/workflows/Test.yml

@@ -9,12 +9,16 @@ on:
             - "frontend/**"
             - "frontend-bundler/**"
             - "frontend-dist/**"
+            - "test/frontend/**"
             - "**.md"
         branches:
             - main
     pull_request:
         paths-ignore:
             - "frontend/**"
+            - "frontend-bundler/**"
+            - "frontend-dist/**"
+            - "test/frontend/**"
             - "**.md"
         branches-ignore:
             - release
@@ -23,24 +27,27 @@ on:
 jobs:
     test:
         runs-on: ${{ matrix.os }}
-        timeout-minutes: 40
-        # Uncomment if you want to see all results for all OSses. Otherwise, the first failed test cancels all others
-        # continue-on-error: true
+        timeout-minutes: 50
+
         strategy:
+            # Without setting this, a failing test cancels all others
+            fail-fast: false
             matrix:
                 # We test quite a lot of versions because we do some OS and version specific things unfortunately
-                julia-version: ["1.5", "1.6", "1.7"] #, "nightly"]
+                julia-version: ["1.6", "1.8", "1.10", "nightly"] # "~1.11.0-0"]
                 os: [ubuntu-latest, macOS-latest, windows-latest]
 
         steps:
             # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v3
 
-            # Makes thes `julia` command available
+            # Makes the `julia` command available
             - uses: julia-actions/setup-julia@v1
               with:
                   version: ${{ matrix.julia-version }}
+            - uses: julia-actions/cache@v1
 
             # 🚗
             - uses: julia-actions/julia-runtest@v1
-              continue-on-error: ${{ matrix.julia-version == 'nightly' }}
+              with:
+                  coverage: false

.github/workflows/TestBundledExport.yml

@@ -0,0 +1,31 @@
+name: Test bundled HTML export
+
+on:
+    push:
+        branches:
+            - release
+
+jobs:
+    frontend-test:
+        runs-on: "ubuntu-latest"
+
+        steps:
+            - uses: actions/checkout@v3
+
+            - uses: julia-actions/setup-julia@v1
+              with:
+                  version: "1.8"
+
+            - name: Generate exports and check for warnings
+              run: |
+                julia --project=$GITHUB_WORKSPACE -e '
+                  import Pkg
+                  Pkg.activate(".")
+                  Pkg.instantiate()
+                  import Pluto
+                  using Test
+
+                  @test_logs Pluto.generate_html()
+                  @test_logs Pluto.generate_index_html()
+                  '
+