chore(release): 2.7.3

fomantic · Apr 2, 2019 · a577bc0 · a577bc0
2 parents 7f44790 + 781bd15
commit a577bc0
Show file tree

Hide file tree

Showing 49 changed files with 626 additions and 485 deletions.
diff --git a/definitions/behaviors/api.js b/definitions/behaviors/api.js
@@ -577,7 +577,7 @@ $.api = $.fn.api = function(parameters) {
                 if(xhr !== undefined) {
                   module.debug('XHR produced a server error', status, httpMessage);
                   // make sure we have an error to display to console
-                  if( xhr.status != 200 && httpMessage !== undefined && httpMessage !== '') {
+                  if( (xhr.status < 200 || xhr.status >= 300) && httpMessage !== undefined && httpMessage !== '') {
                     module.error(error.statusMessage + httpMessage, ajaxSettings.url);
                   }
                   settings.onError.call(context, errorMessage, $module, xhr);

diff --git a/definitions/behaviors/form.js b/definitions/behaviors/form.js
@@ -473,8 +473,7 @@ $.fn.form = function(parameters) {
                 keys     = Object.keys(parameters),
                 isLegacySettings = (keys.length > 0)
                   ? (parameters[keys[0]].identifier !== undefined && parameters[keys[0]].rules !== undefined)
-                  : false,
-                ruleKeys
+                  : false
               ;
               if(isLegacySettings) {
                 // 1.x (ducktyped)
@@ -581,7 +580,6 @@ $.fn.form = function(parameters) {
             $fields.each(function(index, field) {
               var
                 $field     = $(field),
-                type       = $field.prop('type'),
                 name       = $field.prop('name'),
                 value      = $field.val(),
                 isCheckbox = $field.is(selector.checkbox),
@@ -764,12 +762,12 @@ $.fn.form = function(parameters) {
                 ? rule
                 : [rule]
             ;
-            if(rule == undefined) {
-              module.debug('Removed all rules');
-              validation[field].rules = [];
+            if(validation[field] === undefined || !Array.isArray(validation[field].rules)) {
               return;
             }
-            if(validation[field] == undefined || !Array.isArray(validation[field].rules)) {
+            if(rule === undefined) {
+              module.debug('Removed all rules');
+              validation[field].rules = [];
               return;
             }
             $.each(validation[field].rules, function(index, rule) {
@@ -792,7 +790,7 @@ $.fn.form = function(parameters) {
           // alias
           rules: function(field, rules) {
             if(Array.isArray(field)) {
-              $.each(fields, function(index, field) {
+              $.each(field, function(index, field) {
                 module.remove.rule(field, rules);
               });
             }
@@ -924,8 +922,7 @@ $.fn.form = function(parameters) {
 
           form: function(event, ignoreCallbacks) {
             var
-              values = module.get.values(),
-              apiRequest
+              values = module.get.values()
             ;
 
             // input keydown event will fire submit repeatedly by browser default
@@ -1035,14 +1032,13 @@ $.fn.form = function(parameters) {
           rule: function(field, rule, internal) {
             var
               $field       = module.get.field(field.identifier),
-              type         = rule.type,
               ancillary    = module.get.ancillaryValue(rule),
               ruleName     = module.get.ruleName(rule),
               ruleFunction = settings.rules[ruleName],
               invalidFields = [],
-              isRadio = $field.is(selector.radio),
+              isCheckbox = $field.is(selector.checkbox),
               isValid = function(field){
-                var value = (isRadio ? $(field).filter(':checked').val() : $(field).val());
+                var value = (isCheckbox ? $(field).filter(':checked').val() : $(field).val());
                 // cast to string avoiding encoding special values
                 value = (value === undefined || value === '' || value === null)
                     ? ''
@@ -1055,7 +1051,7 @@ $.fn.form = function(parameters) {
               module.error(error.noRule, ruleName);
               return;
             }
-            if(isRadio) {
+            if(isCheckbox) {
               if (!isValid($field)) {
                 invalidFields = $field;
               }
@@ -1554,7 +1550,6 @@ $.fn.form.settings = {
     // matches another field
     match: function(value, identifier) {
       var
-        $form = $(this),
         matchingValue
       ;
       if( $('[data-validate="'+ identifier +'"]').length > 0 ) {
@@ -1579,7 +1574,6 @@ $.fn.form.settings = {
     different: function(value, identifier) {
       // use either id or name of field
       var
-        $form = $(this),
         matchingValue
       ;
       if( $('[data-validate="'+ identifier +'"]').length > 0 ) {

diff --git a/definitions/behaviors/state.js b/definitions/behaviors/state.js
@@ -29,7 +29,6 @@ $.fn.state = function(parameters) {
 
     moduleSelector  = $allModules.selector || '',
 
-    hasTouch        = ('ontouchstart' in document.documentElement),
     time            = new Date().getTime(),
     performance     = [],
 

diff --git a/definitions/behaviors/visibility.js b/definitions/behaviors/visibility.js
@@ -62,7 +62,6 @@ $.fn.visibility = function(parameters) {
 
         $placeholder,
 
-        selector        = $module.selector || '',
         instance        = $module.data(moduleNamespace),
 
         requestAnimationFrame = window.requestAnimationFrame
@@ -510,8 +509,7 @@ $.fn.visibility = function(parameters) {
 
         passed: function(amount, newCallback) {
           var
-            calculations   = module.get.elementCalculations(),
-            amountInPixels
+            calculations   = module.get.elementCalculations()
           ;
           // assign callback
           if(amount && newCallback) {

diff --git a/definitions/collections/form.less b/definitions/collections/form.less
@@ -277,7 +277,8 @@
 
 .ui.form .success.message,
 .ui.form .warning.message,
-.ui.form .error.message {
+.ui.form .error.message,
+.ui.form .error.message:empty {
   display: none;
 }
 

diff --git a/definitions/collections/menu.less b/definitions/collections/menu.less
@@ -392,6 +392,10 @@
   .ui.menu:not(.secondary):not(.text):not(.tabular):not(.borderless) > .container > .item:not(.right):not(.borderless):first-child {
     border-left: @dividerSize solid @dividerBackground;
   }
+  .ui.menu:not(.secondary):not(.text):not(.tabular):not(.borderless) > .container > .right.item:not(.borderless):last-child,
+  .ui.menu:not(.secondary):not(.text):not(.tabular):not(.borderless) > .container > .right.menu > .item:not(.borderless):last-child {
+    border-right: @dividerSize solid @dividerBackground;
+  }
 }
 
 
@@ -455,7 +459,7 @@
      Disabled
 ---------------*/
 
-.ui.menu .item.disabled {
+.ui.ui.menu .item.disabled {
   cursor: default;
   background-color: transparent;
   color: @disabledTextColor;
@@ -1344,7 +1348,7 @@ each(@colors, {
 }
 
 /* Disabled */
-.ui.inverted.menu .item.disabled {
+.ui.ui.inverted.menu .item.disabled {
   color: @invertedDisabledTextColor;
 }
 

diff --git a/definitions/collections/table.less b/definitions/collections/table.less
@@ -875,7 +875,7 @@ each(@colors, {
   color: @invertedCellColor;
   border: @invertedBorder;
 }
-.ui.inverted.table th {
+.ui.ui.inverted.table th {
   background-color: @invertedHeaderBackground;
   border-color: @invertedHeaderBorderColor;
   color: @invertedHeaderColor;
@@ -891,7 +891,12 @@ each(@colors, {
   pointer-events: none;
   color: @invertedDisabledTextColor;
 }
-
+.ui.inverted.table tr td.disabled:not([class="disabled"]),
+.ui.inverted.table tr.disabled:not([class="disabled"]) td,
+.ui.inverted.table tr.disabled td[class]:not(.disabled),
+.ui.inverted.table tr:hover td.disabled:not([class="disabled"]) {
+  color: @disabledTextColor;
+}
 /* Definition */
 .ui.inverted.definition.table tfoot:not(.full-width) th:first-child,
 .ui.inverted.definition.table thead:not(.full-width) th:first-child {
@@ -965,6 +970,9 @@ each(@colors, {
 .ui.celled.table tr td {
   border-left: @cellBorder;
 }
+.ui.inverted.celled.table tr td {
+  border-left: @invertedCellBorder;
+}
 .ui.celled.table tr th:first-child,
 .ui.celled.table tr td:first-child {
   border-left: none;

diff --git a/definitions/elements/button.less b/definitions/elements/button.less
@@ -1039,13 +1039,6 @@
   border-bottom-left-radius: @borderRadius;
 }
 
-/* Fluid Labeled */
-.ui.fluid[class*="left labeled"].icon.button,
-.ui.fluid[class*="right labeled"].icon.button {
-  padding-left: @horizontalPadding !important;
-  padding-right: @horizontalPadding !important;
-}
-
 /* Loading Icon in Labeled Button */
 .ui.labeled.icon.button > .loading.icon:before {
   animation: loader 2s linear infinite;
@@ -1771,7 +1764,7 @@ each(@colors, {
     box-shadow: 0 0 0 @basicColoredBorderSize @@_backgroundColorDown inset;
     color: @@_backgroundColorDown;
   }
-  .ui.buttons:not(.vertical) > .basic.primary.button:not(:first-child) {
+  .ui.buttons:not(.vertical) > .basic.@{consequence}.button:not(:first-child) {
     margin-left: -@basicColoredBorderSize;
   }
 }
@@ -1818,8 +1811,7 @@ each(@colors, {
   border-radius: 0;
   margin: @groupButtonOffset;
 }
-.ui.buttons > .ui.button:not(.basic):not(.inverted),
-.ui.buttons:not(.basic):not(.inverted) > .button {
+.ui.buttons:not(.basic):not(.inverted) > .button:not(.basic):not(.inverted) {
   box-shadow: @groupButtonBoxShadow;
 }
 

diff --git a/definitions/elements/input.less b/definitions/elements/input.less
@@ -512,6 +512,9 @@
 .ui.mini.input {
   font-size: @relativeMini;
 }
+.ui.tiny.input {
+  font-size: @relativeTiny;
+}
 .ui.small.input {
   font-size: @relativeSmall;
 }

diff --git a/definitions/elements/label.less b/definitions/elements/label.less
@@ -308,9 +308,10 @@ a.ui.label {
 
 .ui.corner.label .icon {
   cursor: inherit;
-  position: relative;
+  position: absolute;
   top: @cornerIconTopOffset;
-  left: @cornerIconLeftOffset;
+  left: auto;
+  right: @cornerIconRightOffset;
   font-size: @cornerIconSize;
   margin: 0;
 }
@@ -330,7 +331,8 @@ a.ui.label {
   border-top-color: inherit;
 }
 .ui.left.corner.label .icon {
-  left: -@cornerIconLeftOffset;
+  left: @cornerIconLeftOffset;
+  right: auto;
 }
 
 /* Segment */

diff --git a/definitions/elements/segment.less b/definitions/elements/segment.less
@@ -61,6 +61,7 @@
 --------------------*/
 
 /* Header */
+.ui.inverted.segment > .ui.header > .sub.header,
 .ui.inverted.segment > .ui.header {
   color: @white;
 }
@@ -427,12 +428,13 @@
 }
 
 /* Horizontal Segment */
-.ui.horizontal.segments > .segment {
+.ui.horizontal.segments:not(.compact) > .segment:not(.compact) {
   flex: 1 1 auto;
   -ms-flex: 1 1 0; /* Solves #2550 MS Flex */
+}
+.ui.horizontal.segments > .segment {
   margin: 0;
   min-width: 0;
-  background-color: transparent;
   border-radius: 0;
   border: none;
   box-shadow: none;
@@ -527,11 +529,9 @@
 --------------------*/
 
 .ui.clearing.segment:after {
-  content: ".";
+  content: "";
   display: block;
-  height: 0;
   clear: both;
-  visibility: hidden;
 }
 
 /*-------------------

diff --git a/definitions/elements/step.less b/definitions/elements/step.less
@@ -263,20 +263,28 @@
     flex-direction: column;
     border-radius: @borderRadius;
     padding: @verticalPadding @horizontalPadding;
+    border-right: none;
+    border-bottom: @stepsBorder;
   }
   .ui.steps:not(.unstackable) .step:first-child {
     padding: @verticalPadding @horizontalPadding;
     border-radius: @stepsBorderRadius @stepsBorderRadius 0 0;
   }
   .ui.steps:not(.unstackable) .step:last-child {
     border-radius: 0 0 @stepsBorderRadius @stepsBorderRadius;
+    border-bottom: none;
   }
 
   /* Arrow */
   .ui.steps:not(.unstackable) .step:after {
-    display: none !important;
+    top: unset;
+    bottom: -@arrowSize;
+    right: 50%;
+    transform: translateY(-50%) translateX(50%) rotate(45deg);
+  }
+  .ui.vertical.steps .active.step:last-child:after {
+    display: none;
   }
-
   /* Content */
   .ui.steps:not(.unstackable) .step .content {
     text-align: center;
@@ -394,18 +402,24 @@
   flex-direction: column;
   border-radius: @borderRadius;
   padding: @verticalPadding @horizontalPadding;
+  border-right: none;
+  border-bottom: @stepsBorder;
 }
 .ui[class*="tablet stackable"].steps .step:first-child {
   padding: @verticalPadding @horizontalPadding;
   border-radius: @stepsBorderRadius @stepsBorderRadius 0 0;
 }
 .ui[class*="tablet stackable"].steps .step:last-child {
   border-radius: 0 0 @stepsBorderRadius @stepsBorderRadius;
+  border-bottom: none;
 }
 
 /* Arrow */
 .ui[class*="tablet stackable"].steps .step:after {
-  display: none !important;
+  top: unset;
+  bottom: -@arrowSize;
+  right: 50%;
+  transform: translateY(-50%) translateX(50%) rotate(45deg);
 }
 
 /* Content */

diff --git a/definitions/globals/site.js b/definitions/globals/site.js
@@ -30,7 +30,6 @@ $.site = $.fn.site = function(parameters) {
     namespace       = settings.namespace,
     error           = settings.error,
 
-    eventNamespace  = '.' + namespace,
     moduleNamespace = 'module-' + namespace,
 
     $document       = $(document),

diff --git a/definitions/globals/site.less b/definitions/globals/site.less
@@ -43,7 +43,6 @@ body {
   font-size: @fontSize;
   line-height: @lineHeight;
   color: @textColor;
-  font-smoothing: @fontSmoothing;
 }
 
 /*******************************

diff --git a/definitions/modules/accordion.js b/definitions/modules/accordion.js
@@ -34,12 +34,6 @@ $.fn.accordion = function(parameters) {
     methodInvoked   = (typeof query == 'string'),
     queryArguments  = [].slice.call(arguments, 1),
 
-    requestAnimationFrame = window.requestAnimationFrame
-      || window.mozRequestAnimationFrame
-      || window.webkitRequestAnimationFrame
-      || window.msRequestAnimationFrame
-      || function(callback) { setTimeout(callback, 0); },
-
     returnedValue
   ;
   $allModules