Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out legend into a separate HTML element and adjust chart widths #15

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

nigeldeakin
Copy link
Contributor

In this change I have rewritten the legend code so that the legend is a separate div which we can style directly. Previously the legend was part of the chart canvas so we could to control it directly. The legend is now floated on top of the chart, with each legend entry in a neat vertical list.

I have also changed the responsive styles used to determine how many charts are displayed in a row. This is very easy to change, but currently I have it so that
Displays wider than 1500px: 4 charts/row
Displays wider than 1160px up to 1499: 3 charts/row
Displays wider than 450px up to 1159: 2 charts/row
Displays narrower than 449px: 1 chart/row
The transitions are defined at the bottom of StatsChart.vue. Inevitably close to the transition points the chart may be wider or narrower than is ideal: this is a matter of judgement.

Screenshots:
1500px browser width
functions ui - mozilla firefox 26092017 171022
1160px browser width
functions ui - mozilla firefox 26092017 171043
450px browser width
functions ui - mozilla firefox 26092017 171103
400px browser width
functions ui - mozilla firefox 26092017 171114

px browser**

Copy link
Contributor

@hibooboo2 hibooboo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 What happens when there are a ton of functions registered?

@carimura carimura merged commit 4508b2e into master Sep 26, 2017
@nigeldeakin
Copy link
Contributor Author

nigeldeakin commented Sep 27, 2017

@hibooboo2 If there are lots of functions then the chart has lots of lines on it, and the legend above it had many rows.

I have suggested that I add charts to the "app" page (the page you see if you click on a particular app) that show only the functions for that app. That might make things more manageable (and would be fairly easy to implement). Also I could add charts for individual functions. I've logged issue #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants