Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature gate to work with latest embassy. #6

Closed
wants to merge 3 commits into from

Conversation

bentwire
Copy link
Contributor

Probably needs some cleanup..

@bentwire
Copy link
Contributor Author

Hmm not sure why the build is failing. I didn't set those options...

@fmckeogh
Copy link
Owner

@bentwire If embassy seems to be replacing RTIC in the ecosystem I'm more than happy to just make this an embassy-first library and if anyone needs the original time implementation they can add a compat feature, does that work for you?

@bentwire
Copy link
Contributor Author

I'm fine with that. Its supposed to go live (posted to crates.io) in the next week as soon as some features get in to stable compiler.

So far I like it. Only been messing with it for a week though.

@fmckeogh
Copy link
Owner

@bentwire You're the only library user right now and the project I'm doing is easy to move to a new framework. Ideally I'd like to avoid using features for as long as possible.

@bentwire
Copy link
Contributor Author

@fmckeogh

Yes I agree the features make it ugly. The one thing I like about embassy is async. I think this lib could benefit from embassy for that reason alone.

I'm fine with doing a full async port to embassy if you are.

@bentwire
Copy link
Contributor Author

@fmckeogh
I could start by just moving to embassy blocking as the code works as is with it, and that is how I am using it currently.

@bentwire
Copy link
Contributor Author

I think I need to add a rust-toolchain.toml to fox that build failure. At least until embassy is on stable rust.

Hopefully it won't be too much longer. They are waiting for a couple features related to async getting in stable.

@fmckeogh
Copy link
Owner

fmckeogh commented May 4, 2024

Superseded by #10

@fmckeogh fmckeogh closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants