add recursive cache for private modules #2928
Draft
+242
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
See #2912 for more context.
Make caching easier to use in flytekit by reducing cognitive burden of specifying cache versions.
What changes were proposed in this pull request?
In this change we add a class to recursively explore the any functions and class methods defined in the users repo and called within a function of interest. The hash of each user defined function or method computed and hashed together to generate a single unique hash.
This covers the following scenarios:
import my_module
,print(my_module.var)
from my_module import var
How was this patch tested?
Since
get_version
is already tested in #2912, we just ensure that the correct callables are extracted for hashing. We set up a mock package and make sure all of the above conditions are satisfied.Will eventually separate tests out so failures can be more easily diagnosed.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link