page indicator for fixed layouts #1153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doublonmousse
commented
Jul 22, 2024
Comment on lines
+511
to
+517
| // at the center of the viewport instead | ||
| let page_number = ((canvas.engine_ref().camera.offset().y + 0.01) | ||
| / (canvas.engine_ref().document.format.height() | ||
| * canvas.engine_ref().camera.zoom())) | ||
| .ceil() | ||
| .max(1.0); | ||
| self.main_header().page_spin().set_value(page_number); |
There was a problem hiding this comment.
I should probably only trigger the set_value if the page number is actually different from the actual value
- use
block_signal/unblock_signalon thepage_spinso that the function to change the page isn't called twice (thanks @Clemapfel for the idea)
There was a problem hiding this comment.
Seems like doing this is harder than it seems because glib::signal::SignalHandlerId does not implement Clone, hence it's difficult to save the value and use it in another function to block/unblock things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #639
Screencast_20240722_132148.webm
This does not include any page menu, only a page number indicator to show the current page number and change the page. For now this is only implemented for fixed layouts (infinite layouts would need a little more work as page positions and number depend on a little more than the current canvas size, like which pages include strokes. Having a page number might be a little more difficult as well).
There's probably a few things to improve (these are suggestions)