-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transition bionic containers to jammy #1057
Conversation
ea0b610
to
de52f4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but honestly I'd consider just squashing all these commits into one big commit with a nice descriptive commit message saying something like ci: replace bionic with jammy and bookworm
with a nice explanation in the message "bionic is out of LTS, etc" so update to jammy and add a bookworm image since flux-core has one, etc.
If you want to keep a couple separate commits that's fine too, but they'd need commit message to give slightly more detail.
And THANK YOU for doing this!
Thanks @grondo. Most of these are squashed out, all the container oriented commits are. There's a larger commit message, and updated to only build one jammy output along with using bookworm for most tests. |
This is an image update/rework for our CI. Since bionic has fallen out of LTS standard support, the original plan was to update to Jammy and move on. There's more here than that because Jammy doesn't provide a 386 container build anymore. To fill in that gap, we also have a Debian bookworm container, which is now the default target. There is also a Jammy build in here to keep an ubuntu LTS current container going, but the Ubuntu side is painful enough that most of the tests are now on bookworm. Additionally: * el7 is dropped * fedora outside of 34 (forked to el9) and current are dropped * docker-checks-run script updated from matching PR in core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @trws
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
========================================
- Coverage 74.4% 72.6% -1.9%
========================================
Files 86 80 -6
Lines 9434 10243 +809
========================================
+ Hits 7020 7437 +417
- Misses 2414 2806 +392 |
transition bionic containers to jammy
This may end up having to merge before the tests on flux-core's version can pass, because of the flux-sched test run. Hoping to get a jump on it here, somehow need to break the cycle.